On Mon, Jun 22, 2009 at 10:07:27AM +0800, Huang Ying wrote:
>
> Oh, I see. I will do this.
Just to be clear, it should be added to gcm_base, not gcm.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http:
On Mon, 2009-06-22 at 10:03 +0800, Herbert Xu wrote:
> On Mon, Jun 22, 2009 at 09:41:16AM +0800, Huang Ying wrote:
> >
> > Can crypto_alloc_ahash("ghash",...) select among different ghash
> > implementation automatically based on priority? I think
> > crypto_alloc_ablkcipher("cbc(aes)",...) can sel
On Mon, Jun 22, 2009 at 09:41:16AM +0800, Huang Ying wrote:
>
> Can crypto_alloc_ahash("ghash",...) select among different ghash
> implementation automatically based on priority? I think
> crypto_alloc_ablkcipher("cbc(aes)",...) can select among different AES
> implementation automatically. They ar
On Sun, 2009-06-21 at 21:46 +0800, Herbert Xu wrote:
> Huang Ying wrote:
> >
> > + ghash = crypto_alloc_ahash("ghash", 0, 0);
> > + if (IS_ERR(ghash))
> > + return PTR_ERR(ghash);
>
> We should add this as an extra parameter to gcm_base. This is
> so that the user can s
Hi Linus:
This push fixes a number of regressions for hardware AES:
* Spurious page faults with AES on Via Nano.
* Fix broken decryption with Intel AES.
* Fix atomic sleep with Intel AES.
Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git
or
master.kernel.or
Shasi Pulijala wrote:
> Hi,
>I am re-sending this patch as a patch series of 3, I am assuming the
> earlier one did not go through the mailing lists
> because it was over the size limit.
Actually the original patch came through the list and to me :)
However I'm not against splitting it
Huang Ying wrote:
> PCLMULQDQ is used to accelerate the most time-consuming part of GHASH,
> carry-less multiplication. More information about PCLMULQDQ can be
> found at:
>
> http://software.intel.com/en-us/articles/carry-less-multiplication-and-its-usage-for-computing-the-gcm-mode/
>
> Because
Huang Ying wrote:
> cryptd_alloc_ahash() will allocate a cryptd-ed ahash for specified
> algorithm name. The new allocated one is guaranteed to be cryptd-ed
> ahash, so the shash underlying can be gotten via cryptd_ahash_child().
>
> Signed-off-by: Huang Ying
Looks good too.
--
Visit Openswan
Huang Ying wrote:
> crypto_hash interface has some issue and will be replaced by
> crypto_shash. This patch replace crypto_hash in cryptd hash with
> crypto_shash.
>
> Signed-off-by: Huang Ying
This patch and 3/7 looks good to me.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: H
Huang Ying wrote:
>
> + ghash = crypto_alloc_ahash("ghash", 0, 0);
> + if (IS_ERR(ghash))
> + return PTR_ERR(ghash);
We should add this as an extra parameter to gcm_base. This is
so that the user can select an alternative ghash implementation.
Cheers,
--
Visit Openswa
10 matches
Mail list logo
