Re: crypto: ansi_cprng - Do not select FIPS

2009-06-19 Thread Herbert Xu
On Fri, Jun 19, 2009 at 08:55:00AM -0400, Neil Horman wrote: > > Thanks! Thats definately an oversight. Likely I included it because I was > implementing it as part of the FIPS effort. The CPRNG definately works fine, > even if fips is disabled. Although I think the relationship should be > re

Re: crypto: ansi_cprng - Do not select FIPS

2009-06-19 Thread Neil Horman
On Fri, Jun 19, 2009 at 08:34:00PM +0800, Herbert Xu wrote: > Hi Neil: > > Why does the CPRNG select FIPS? It should work with FIPS off > too, no? > Thanks! Thats definately an oversight. Likely I included it because I was implementing it as part of the FIPS effort. The CPRNG definately works

Re: [PATCH] tcrypt: Test algorithms by name

2009-06-19 Thread Herbert Xu
On Fri, Jun 19, 2009 at 07:47:37PM +0800, Herbert Xu wrote: > On Fri, Jun 19, 2009 at 01:40:58PM +0200, Steffen Klassert wrote: > > This adds the 'alg' module parameter to be able to test an > > algorithm by name. If the algorithm type is not ad-hoc > > clear for a algorithm (e.g. pcrypt, cryptd) i

crypto: ansi_cprng - Do not select FIPS

2009-06-19 Thread Herbert Xu
Hi Neil: Why does the CPRNG select FIPS? It should work with FIPS off too, no? commit 27300176d75e4723e2125e745a98a77bf0133f72 Author: Herbert Xu Date: Fri Jun 19 20:32:58 2009 +0800 crypto: ansi_cprng - Do not select FIPS The RNG should work with FIPS disabled. Signed-o

Re: [RFC] [PATCH 2/5] pcrypt: Add pcrypt crypto parallelization wrapper

2009-06-19 Thread Herbert Xu
On Mon, Jun 08, 2009 at 09:10:00AM +0200, Steffen Klassert wrote: > > +config CRYPTO_PCRYPT > + tristate "Parallel crypto engine (EXPERIMENTAL)" > + depends on USE_GENERIC_SMP_HELPERS && EXPERIMENTAL > + select CRYPTO_MANAGER > + select CRYPTO_PCRYPT_CORE > + help > + This

Re: [RFC] [PATCH 2/5] pcrypt: Add pcrypt crypto parallelization wrapper

2009-06-19 Thread Herbert Xu
On Mon, Jun 08, 2009 at 09:10:00AM +0200, Steffen Klassert wrote: > > +config CRYPTO_PCRYPT_CORE > + bool > + select CRYPTO_AEAD BTW just noticed that this forces AEAD to be built-in even when pcrypt is a module. We should fix this up. Thanks, -- Visit Openswan at http://www.openswan.or

Re: [PATCH] tcrypt: Test algorithms by name

2009-06-19 Thread Herbert Xu
On Fri, Jun 19, 2009 at 01:40:58PM +0200, Steffen Klassert wrote: > This adds the 'alg' module parameter to be able to test an > algorithm by name. If the algorithm type is not ad-hoc > clear for a algorithm (e.g. pcrypt, cryptd) it is possilbe > to set the algorithm type with the 'type' module par

[PATCH] tcrypt: Test algorithms by name

2009-06-19 Thread Steffen Klassert
This adds the 'alg' module parameter to be able to test an algorithm by name. If the algorithm type is not ad-hoc clear for a algorithm (e.g. pcrypt, cryptd) it is possilbe to set the algorithm type with the 'type' module parameter. Signed-off-by: Steffen Klassert --- crypto/tcrypt.c | 15

Re: [RFC] [PATCH 5/5] tcrypt: Test algorithms by name

2009-06-19 Thread Herbert Xu
On Fri, Jun 19, 2009 at 06:53:25PM +0800, Herbert Xu wrote: > On Mon, Jun 08, 2009 at 09:12:46AM +0200, Steffen Klassert wrote: > > This adds the 'alg' module parameter to be able to test an > > algorithm by name. If the algorithm type is not ad-hoc > > clear for a algorithm (e.g. pcrypt, cryptd) i

Re: [RFC] [PATCH 5/5] tcrypt: Test algorithms by name

2009-06-19 Thread Herbert Xu
On Mon, Jun 08, 2009 at 09:12:46AM +0200, Steffen Klassert wrote: > This adds the 'alg' module parameter to be able to test an > algorithm by name. If the algorithm type is not ad-hoc > clear for a algorithm (e.g. pcrypt, cryptd) it is possilbe > to set the algorithm type with the 'type' module par