Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

2009-06-01 Thread Herbert Xu
Ben Hutchings wrote: > > I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS > declaration or (2) making the module initialisation function fail if the > device is not present. The latter behaviour is generally wrong for PCI > drivers, but this device presumably cannot be ho

Re: sha384 self-test failure oddity

2009-06-01 Thread Herbert Xu
Jarod Wilson wrote: > While doing a bit of testing of some other crypto code, I've repeatedly > noticed a sha384 self-test failure. If you 'modprobe tcrypt', the > sha384 self-test fails, then immediately after it, sha384-generic > self-tests succeed. Something is awry w/sha384 initialization, as

Re: [RFC] [PATCH 2/5] aead: Add generic aead wrapper interface

2009-06-01 Thread Herbert Xu
On Wed, May 13, 2009 at 03:08:18PM +0200, Steffen Klassert wrote: > This patch adds an interface to wrap aead algorithms with an > arbitrary crypto template. This is useful to make a certain > version of an aead algorithm the system default of that algorithm. > > Signed-off-by: Steffen Klassert

Re: [RFC] [PATCH 2/5] aead: Add generic aead wrapper interface

2009-06-01 Thread Herbert Xu
On Wed, May 13, 2009 at 03:08:18PM +0200, Steffen Klassert wrote: > This patch adds an interface to wrap aead algorithms with an > arbitrary crypto template. This is useful to make a certain > version of an aead algorithm the system default of that algorithm. > > Signed-off-by: Steffen Klassert

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-06-01 Thread Herbert Xu
Alan Cox wrote: > > Zeroing long term keys makes sense but for the short lifepsan keys used on > the wire its a bit pointless irrespective of speed (I suspect done > properly the performance impact would be close to nil anyway) Sure, though we're not actually arguing whether keys should be zeroed

Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling

2009-06-01 Thread Alan Cox
On Mon, 1 Jun 2009 14:48:37 +1000 Herbert Xu wrote: > On Sun, May 31, 2009 at 09:46:23PM -0700, David Miller wrote: > > > > I don't even want to think about what this does to IPSEC rule creation > > rates, that that matters heavily for cell phone networks where > > hundreds of thousands of nodes