Re: [PATCH] The VIA Hardware RNG driver is for the CPU, not Chipset

2009-05-10 Thread Harald Welte
Dear Arjan, it seems like it is probably a pragmatic solution to first merge your suggested changes (Kconfig enable for X86_64 as well as skipping any MSR activity), before adressing the auto-loading in a potential follow-up patch. I have sent your modifications (split in two patches, with some a

[PATCH] Support VIA Nano hardware RNG on X86_64 builds

2009-05-10 Thread Harald Welte
Fix Kconfig to build via-rng.ko on X86_64 builds, as the VIA Nano CPU supports x86_64, too. Signed-off-by: Harald Welte --- drivers/char/hw_random/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig ind

[PATCH] Support VIA Nano hardware RNG

2009-05-10 Thread Harald Welte
Support VIA Nano hardware RNG The VIA Nano CPU supports the same XSTORE instruction based RNG, but it lacks the MSR present in earlier CPUs. Signed-off-by: Harald Welte diff --git a/drivers/char/hw_random/via-rng.c b/drivers/char/hw_random/via-rng.c index 4e9573c..794aacb 100644 --- a/drivers/c

Re: [PATCH] The VIA Hardware RNG driver is for the CPU, not Chipset

2009-05-10 Thread Harald Welte
Dear Arjan, On Mon, May 11, 2009 at 02:12:17AM +0200, Arjan Koers wrote: > Harald Welte wrote: > > This is a cosmetic change, fixing the MODULE_DESCRIPTION() of via-rng.c > > Coincidentally, I was trying to make my RNG work for x86_64 today and I > was wondering about this. I like those coincid

Re: [PATCH] Enable VIA PadLock on x86_64

2009-05-10 Thread Harald Welte
On Mon, May 11, 2009 at 12:03:41AM +0800, Harald Welte wrote: > [CRYPTO] Support VIA PadLock hardware crypto on x86-64 Sorry, I should have read the list archives before posting. Please apply the more correct patch from Sebastian Andrzej Siewior as available since March 14 at http://www.mail-arc

Re: [PATCH] The VIA Hardware RNG driver is for the CPU, not Chipset

2009-05-10 Thread Arjan Koers
Harald Welte wrote: > This is a cosmetic change, fixing the MODULE_DESCRIPTION() of via-rng.c Coincidentally, I was trying to make my RNG work for x86_64 today and I was wondering about this. How can multiple RNGs in current dual-processor setups and in the future multicore Nano be handled? The

Re: [PATCH] Enable VIA PadLock on x86_64

2009-05-10 Thread Herbert Xu
On Mon, May 11, 2009 at 12:03:41AM +0800, Harald Welte wrote: > [CRYPTO] Support VIA PadLock hardware crypto on x86-64 > > The VIA Nano CPU supports x86_64, so it is now wrong to assume PadLock > would only exist on X86_32 builds. > > This patch just alters Kconfig to reflect this fact, as well

[PATCH] Enable VIA PadLock on x86_64

2009-05-10 Thread Harald Welte
[CRYPTO] Support VIA PadLock hardware crypto on x86-64 The VIA Nano CPU supports x86_64, so it is now wrong to assume PadLock would only exist on X86_32 builds. This patch just alters Kconfig to reflect this fact, as well as a trivial one-line fix to an assembly statement in padlock-aes.c Signe

[RFC] how to auto-load via-rng ?

2009-05-10 Thread Harald Welte
Hi! I've been trying to come up with a method to automatically load the via-rng.ko kernel module on systems that support the hardware RNG. Right now the kernel builds the module, but almost nobody uses it, since it is not automatically loaded. I was thinking of creating a platform device from ar

[PATCH] The VIA Hardware RNG driver is for the CPU, not Chipset

2009-05-10 Thread Harald Welte
This is a cosmetic change, fixing the MODULE_DESCRIPTION() of via-rng.c Signed-off-by: Harald Welte --- drivers/char/hw_random/via-rng.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hw_random/via-rng.c b/drivers/char/hw_random/via-rng.c index eea0814..82