Re: Accelerate GCM with PCLMULQDQ-NI

2009-03-29 Thread Huang Ying
On Sun, 2009-03-29 at 15:43 +0800, Herbert Xu wrote: > On Wed, Mar 18, 2009 at 04:52:12PM +0800, Huang Ying wrote: > > > > To accelerate GCM with it, I make the following design: > > > > 1. Implement ghash as an ahash algorithm, Use ghash in gcm > > implementation. > > 2. Provide a new implementat

Re: [PATCH 1/5 RESEND] crypto: talitos - scaffolding for new algorithm types

2009-03-29 Thread Herbert Xu
On Fri, Mar 27, 2009 at 10:48:54PM -0500, Kim Phillips wrote: > From: Lee Nipper > > This patch is preparation for adding new algorithm types. > > Some elements which are AEAD specific were renamed. > The algorithm template structure was changed to > use crypto_alg, and talitos_alg_alloc was mad

Re: [PATCH] crypto: testmgr - Kill test_comp() sparse warnings

2009-03-29 Thread Herbert Xu
On Wed, Mar 25, 2009 at 04:17:17PM +0100, Geert Uytterhoeven wrote: > make C=1: > | crypto/testmgr.c:846:45: warning: incorrect type in argument 5 (different > signedness) > | crypto/testmgr.c:846:45:expected unsigned int *dlen > | crypto/testmgr.c:846:45:got int * > | crypto/testmgr.c:878

Re: Accelerate GCM with PCLMULQDQ-NI

2009-03-29 Thread Herbert Xu
On Wed, Mar 18, 2009 at 04:52:12PM +0800, Huang Ying wrote: > > To accelerate GCM with it, I make the following design: > > 1. Implement ghash as an ahash algorithm, Use ghash in gcm > implementation. > 2. Provide a new implementation of ghash with PCLMULQDQ-NI. > > What do you think about that?

Re: [PATCH -v3 2/3] crypto: Add fpu template, a wrapper for blkcipher touching FPU

2009-03-29 Thread Herbert Xu
On Wed, Mar 18, 2009 at 11:21:57AM +0800, Huang Ying wrote: > Blkcipher touching FPU need to be enclosed by kernel_fpu_begin() and > kernel_fpu_end(). If they are invoked in cipher algorithm > implementation, they will be invoked for each block, so that > performance will be hurt, because they are

Re: [PATCHv3][trivial] crypto: tcrypt - reduce stack size

2009-03-29 Thread Herbert Xu
On Wed, Feb 25, 2009 at 10:32:31AM -0500, Neil Horman wrote: > On Wed, Feb 25, 2009 at 03:53:14PM +0100, Frank Seidel wrote: > > From: Frank Seidel > > > > Applying kernel janitors todos (printk calls need KERN_* > > constants on linebeginnings, reduce stack footprint where > > possible) to tcryp