Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver

2009-03-02 Thread Herbert Xu
On Mon, Mar 02, 2009 at 08:42:39PM +, Russell King - ARM Linux wrote: > > So, sorry, I'm not qualified to review this. Please find someone else > who knows about crypto stuff. No worries, I'm onto it. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home P

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-03-02 Thread Herbert Xu
On Thu, Feb 26, 2009 at 11:20:26PM +, Russell King - ARM Linux wrote: > > I don't think you can use chained scatterlists unless the architecture > supports it. It's not a case that you have to flatten the chaining > before passing it over to the arch - it seems you're not allowed to > create a

[WIP] crypto: add support for Orion5X crypto engine

2009-03-02 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior This is my current status of an async crypto driver for the Orion5X crypto unit. The driver uses the crypto accelerator. The data is copied via memcpy() and will be replaced with idma once the infrastructure around it is working. This patch depends on "arm/orion5x:

Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver

2009-03-02 Thread Russell King - ARM Linux
On Mon, Mar 02, 2009 at 12:45:12PM +0100, Christian Hohnstaedt wrote: > > - keep dma functions away from chained scatterlists. >Use the existing scatterlist iteration inside the driver >to call dma_map_single() for each chunk and avoid dma_map_sg(). Hmm, interesting. So crypto has its o

[PATCH] crypto: fix handling of sg buffers in ixp4xx driver

2009-03-02 Thread Christian Hohnstaedt
- keep dma functions away from chained scatterlists. Use the existing scatterlist iteration inside the driver to call dma_map_single() for each chunk and avoid dma_map_sg(). Signed-off-by: Christian Hohnstaedt Tested-By: Karl Hiramoto --- drivers/crypto/ixp4xx_crypto.c | 182