On Fri, Feb 27, 2009 at 02:51:15PM +0100, Milan Broz wrote:
>
> Is the attached and reworked patch ok?
Looks good to me.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herber
Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 01:28:46PM +0100, Milan Broz wrote:
>> Like this?
>>
>> struct ablkcipher_request *req = (char *)dmreq - cc->dmreq_start;
>> mempool_free(req, cc->req_pool);
>
> Exactly. You could also embed the ablkcipher_request at the
> end of dmreq, as in
>
> struct
On Fri, Feb 27, 2009 at 01:28:46PM +0100, Milan Broz wrote:
>
> Like this?
>
> struct ablkcipher_request *req = (char *)dmreq - cc->dmreq_start;
> mempool_free(req, cc->req_pool);
Exactly. You could also embed the ablkcipher_request at the
end of dmreq, as in
struct dm_crypt_request {
s
Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 12:52:05PM +0100, Milan Broz wrote:
>> Herbert Xu wrote:
>>> On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
@@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
return;
}
- mempool_free(ablkci
On Fri, Feb 27, 2009 at 12:52:05PM +0100, Milan Broz wrote:
> Herbert Xu wrote:
> > On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
> >> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
> >>return;
> >>}
> >>
> >> - mempool_free(ablkcipher_request_cast(asy
Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
>> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
>> return;
>> }
>>
>> -mempool_free(ablkcipher_request_cast(async_req), cc->req_pool);
>> +mempool_free(dmreq->req, cc->req_poo
On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
>
> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
> return;
> }
>
> - mempool_free(ablkcipher_request_cast(async_req), cc->req_pool);
> + mempool_free(dmreq->req, cc->req_pool);
Why do we need
On Fri, Feb 27, 2009 at 09:41:02AM +0100, Milan Broz wrote:
>
> Can you send me backtrace from that panic?
>
> What's wrong in async callback now - mempool_free using async_req directly?
The req you get in the completion function is not necessarily
the req that you started with. The only thing
On Thu, Feb 26, 2009 at 09:27:09PM +0100, Karl Hiramoto wrote:
> Herbert Xu wrote:
>> Russell King - ARM Linux wrote:
>>
>>> We can't merge this until _all_ of ARM has been fixed for walking
>>> scatterlist chains.
>>>
>>
>> Right, this is definitely not the way to fix this bug. Because
>
Hi, Milan,
On Fri, 2009-02-27 at 16:41 +0800, Milan Broz wrote:
> Herbert Xu wrote:
> > On Fri, Feb 27, 2009 at 01:31:56PM +0800, Huang Ying wrote:
> >> I had ever heard from you that the only thing guaranteed in the
> >> completion function of async ablkcipher cryption is the req->data has
> >> t
In async cryption complete function (kcryptd_async_done), the
crypto_async_request passed in may be different from the one passed to
crypto_ablkcipher_encrypt/decrypt. Only crypto_async_request->data is
guaranteed to be same as the passed in one. Current kcryptd_async_done
uses passed in crypto_asy
Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 01:31:56PM +0800, Huang Ying wrote:
>> I had ever heard from you that the only thing guaranteed in the
>> completion function of async ablkcipher cryption is the req->data has
>> the value you set before. The request pointer itself may be changed. But
>>
12 matches
Mail list logo
