Re: [PATCH] crypto: ahash - fix ahash digest size

2009-02-18 Thread Herbert Xu
Lee Nipper wrote: > crypto_ahash_show changed to use cra_ahash for digestsize reference. > > Signed-off-by: Lee Nipper Good catch! Applied to crpyto-2.6. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [PATCH -v2 1/3] crypto: Use dedicated workqueue for crypto subsystem

2009-02-18 Thread Herbert Xu
On Tue, Feb 10, 2009 at 02:13:50PM +0800, Huang Ying wrote: > Use dedicated workqueue for crypto subsystem > > A dedicated workqueue named kcrypto_wq is created to be used by crypto > subsystem. The system shared keventd_wq is not suitable for > encryption/decryption, because of potential starvati

Re: [PATCH 00/10] crypto/des_generic: Code cleanups

2009-02-18 Thread Herbert Xu
On Sun, Feb 08, 2009 at 06:50:07AM -0500, George Spelvin wrote: > These are a bunch of code cleanups I worked out a couple of years ago, > split up into least publishable units. They're logically independent, > although some overlap so will take some fixing to apply without the > earlier ones. Th

Re: [PATCH 1/5] crypto: compress - Add pcomp interface

2009-02-18 Thread Herbert Xu
On Wed, Feb 18, 2009 at 04:53:18PM +0100, Geert Uytterhoeven wrote: > > + int (*compress_setup)(struct crypto_pcomp *tfm, const void *params); I think the lack of a length field is the only thing preventing me from applying this :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

Re: [PATCH] crypto: compress - Add pcomp interface

2009-02-18 Thread Herbert Xu
On Thu, Feb 12, 2009 at 04:19:40PM +0100, Geert Uytterhoeven wrote: > On Tue, 10 Feb 2009, Herbert Xu wrote: > > On Thu, Feb 05, 2009 at 05:24:51PM +0100, Geert Uytterhoeven wrote: > > > > Well with the netlink parameters these can have variable lengths > > > > depending on how many parameters the

Re: [PATCH 5/5] squashfs: Make SquashFS 4 use the new pcomp crypto interface

2009-02-18 Thread Jared Hulbert
> Modify SquashFS 4 to use the new "pcomp" crypto interface for decompression, > instead of calling the underlying zlib library directly. This simplifies e.g. > the addition of support for hardware decompression and different decompression > algorithms. Geert, When did this become an option? I

[PATCH] crypto: ahash - fix ahash digest size

2009-02-18 Thread Lee Nipper
crypto_ahash_show changed to use cra_ahash for digestsize reference. Signed-off-by: Lee Nipper --- Makes digestsize for an ahash to be shown correctly. crypto/ahash.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/ahash.c b/crypto/ahash.c index ba5292d..b2d1ee3

[PATCH 5/5] squashfs: Make SquashFS 4 use the new pcomp crypto interface

2009-02-18 Thread Geert Uytterhoeven
Modify SquashFS 4 to use the new "pcomp" crypto interface for decompression, instead of calling the underlying zlib library directly. This simplifies e.g. the addition of support for hardware decompression and different decompression algorithms. Signed-off-by: Geert Uytterhoeven Cc: Phillip Lough

[PATCH 3/5] crypto: new zlib crypto module, using pcomp

2009-02-18 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven Cc: James Morris --- crypto/Kconfig|8 + crypto/Makefile |1 + crypto/zlib.c | 351 + include/crypto/compress.h | 12 ++ 4 files changed, 372 insertions(+), 0 deletions(-)

[PATCH 4/5] crypto: testmgr - add zlib test

2009-02-18 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- crypto/Kconfig |1 + crypto/tcrypt.c |6 +++- crypto/testmgr.c | 15 + crypto/testmgr.h | 93 ++ 4 files changed, 114 insertions(+), 1 deletions(-) diff --git a/crypto/Kconfig b/crypt

[PATCH 2/5] crypto: testmgr - Add support for the pcomp interface

2009-02-18 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- crypto/testmgr.c | 181 ++ crypto/testmgr.h |9 +++ 2 files changed, 190 insertions(+), 0 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index a75f11f..54b96ed 100644 --- a/crypto/testmg

[PATCH 0/5] Partial (de)compression Crypto API

2009-02-18 Thread Geert Uytterhoeven
The following patch series adds support for partial (de)compression to the CRYPTO API, and modifies SquashFS 4 to use this: [1] crypto: compress - Add pcomp interface [2] crypto: testmgr - Add support for the pcomp interface [3] crypto: new zlib crypto module, using pcomp [4] crypto: test

[PATCH 1/5] crypto: compress - Add pcomp interface

2009-02-18 Thread Geert Uytterhoeven
The current "comp" crypto interface supports one-shot (de)compression only, i.e. the whole data buffer to be (de)compressed must be passed at once, and the whole (de)compressed data buffer will be received at once. In several use-cases (e.g. compressed file systems that store files in big compresse

Re: LRW endian issues?

2009-02-18 Thread Geert Uytterhoeven
On Wed, 18 Feb 2009, Herbert Xu wrote: > On Thu, Feb 12, 2009 at 04:30:11PM +0100, Geert Uytterhoeven wrote: > > > > > Thanks, could you try this patch? > > > > Unfortunately it doesn't seem to make any difference. > > Thanks for testing. I've reproduced the problem here and this > is the fix I'

Re: LRW endian issues?

2009-02-18 Thread Herbert Xu
On Thu, Feb 12, 2009 at 04:30:11PM +0100, Geert Uytterhoeven wrote: > > > Thanks, could you try this patch? > > Unfortunately it doesn't seem to make any difference. Thanks for testing. I've reproduced the problem here and this is the fix I've come up with. commit 6fe4a28d8855e072036f36ee22f0a8

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Geert Uytterhoeven
On Wed, 18 Feb 2009, Herbert Xu wrote: > On Wed, Feb 18, 2009 at 10:59:13AM +0100, Geert Uytterhoeven wrote: > > But if you put stuff in your crypto_* before base, you still need the > > special > > translation (and check for IS_ERR()). > > You've lost me. With my patch crypto_create_tfm will ei

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Herbert Xu
On Wed, Feb 18, 2009 at 10:59:13AM +0100, Geert Uytterhoeven wrote: > > But if you put stuff in your crypto_* before base, you still need the special > translation (and check for IS_ERR()). You've lost me. With my patch crypto_create_tfm will either return the pointer to the start of the area al

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Geert Uytterhoeven
On Wed, 18 Feb 2009, Herbert Xu wrote: > On Wed, Feb 18, 2009 at 10:07:38AM +0100, Geert Uytterhoeven wrote: > > > > Yep, I haven't tried it yet, but it looks OK. > > > > The only caveat is that crypto_*.base must always be at offset zero now. > > Why is that? We still add the size given by the f

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Herbert Xu
On Wed, Feb 18, 2009 at 10:07:38AM +0100, Geert Uytterhoeven wrote: > > Yep, I haven't tried it yet, but it looks OK. > > The only caveat is that crypto_*.base must always be at offset zero now. Why is that? We still add the size given by the frontend. Cheers, -- Visit Openswan at http://www.op

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Geert Uytterhoeven
On Wed, 18 Feb 2009, Herbert Xu wrote: > On Tue, Feb 17, 2009 at 06:46:40PM +0100, Geert Uytterhoeven wrote: > > crypto_alloc_tfm() returns an error-valued pointer in case of failure, > > which must not be translated using __crypto_shash_cast(). > > > > Currently everything works fine because __cr

Re: [PATCH] crypto: shash - Handle failures in crypto_alloc_shash() correctly

2009-02-18 Thread Herbert Xu
On Tue, Feb 17, 2009 at 06:46:40PM +0100, Geert Uytterhoeven wrote: > crypto_alloc_tfm() returns an error-valued pointer in case of failure, > which must not be translated using __crypto_shash_cast(). > > Currently everything works fine because __crypto_shash_cast() is a no-op > (crypto_shash.base