RE: [RFC] MPI module

2009-02-06 Thread Loc Ho
Hi, Sorry for the late response... See inline... -Loc -Original Message- From: Pierre Habouzit [mailto:madco...@debian.org] Sent: Saturday, January 31, 2009 2:35 PM To: Loc Ho Cc: Herbert Xu; linux-crypto@vger.kernel.org Subject: Re: [RFC] MPI module On Fri, Jan 30, 2009 at 06:54:16PM

RE: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-06 Thread Loc Ho
Hi Herbert, I had looked into what you suggested. What about this implementation design below. I will show an implementation for ahash type only: File: algapi.h struct crypto_type { unsigned int (*ctxsize)(struct crypto_alg *alg, u32 type, u32 mask); int (*init)(struct crypto_tf

ablkcipher algorithm with givencrypt

2009-02-06 Thread Lee Nipper
Herbert, I'm implementing ablkcipher algorithms in talitos and need some clarification. If an ablkcipher crypto algorithm implements .givencrypt with geniv as "" what is the reason that it cannot be used as a building block cipher for an IPsec use case ? I've noticed that if an ablkcipher algor

Re: [PATCH] crypto: add missing KERN_* constants to printks

2009-02-06 Thread Frank Seidel
Alexey Dobriyan schrieb: > On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote: >> According to kerneljanitors todo list all printk calls (beginning >> a new line) should have an according KERN_* constant. > > Forget about kernel janitors todo list, fix a bug instead. Sure, i am eager to

Re: [PATCH] crypto: add missing KERN_* constants to printks

2009-02-06 Thread Frank Seidel
Alexey Dobriyan schrieb: > Some messages there were truly debugging and some clearly weren't > WARNING, but INFO. Yes, i also thought so, but i didn't venture to change it to i think it looks like. And as bevor they also were all at the same (unspecified/default) level... Do you think its worth/i

Re: [PATCH] crypto: add missing KERN_* constants to printks

2009-02-06 Thread Alexey Dobriyan
On Fri, Feb 06, 2009 at 03:54:38PM +0100, Frank Seidel wrote: > Alexey Dobriyan schrieb: > > On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote: > >> According to kerneljanitors todo list all printk calls (beginning > >> a new line) should have an according KERN_* constant. > > > > Forge

Re: [PATCH] crypto: add missing KERN_* constants to printks

2009-02-06 Thread Alexey Dobriyan
On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote: > According to kerneljanitors todo list all printk calls (beginning > a new line) should have an according KERN_* constant. Forget about kernel janitors todo list, fix a bug instead. > Those are the missing pieces here for the crypto s

[PATCH] crypto: add missing KERN_* constants to printks

2009-02-06 Thread Frank Seidel
From: Frank Seidel According to kerneljanitors todo list all printk calls (beginning a new line) should have an according KERN_* constant. Those are the missing pieces here for the crypto subsystem. Signed-off-by: Frank Seidel --- crypto/ansi_cprng.c |2 +- crypto/tcrypt.c | 48 +

Re: LRW endian issues?

2009-02-06 Thread Geert Uytterhoeven
On Fri, 6 Feb 2009, Herbert Xu wrote: > Geert Uytterhoeven wrote: > > When running "modprobe tcrypt mode=10" on ppc64 (PS3), I get the following > > error: > > > > | alg: skcipher: Test 8 failed on encryption for lrw(aes-generic) > > | : 1a 1d a9 30 ad f9 2f 9b b6 1d ae ef f0 2f f8 5a >