Re: zeroing tfms in crypto_free_tfm()

2009-02-04 Thread Herbert Xu
On Wed, Feb 04, 2009 at 04:09:04PM +0100, Geert Uytterhoeven wrote: > > However, in the mean time, the allocation mechanism for crypto_tfm objects has > been changed twice, by: > 1. commit fbdae9f3e7fb57c07cb0d973f113eb25da2e8ff2 ("[CRYPTO] Ensure cit_iv > is aligned correctly"), which repla

Re: [PATCH] crypto: shash - fix module refcount

2009-02-04 Thread Herbert Xu
On Fri, Jan 30, 2009 at 09:09:39PM +0100, Adrian-Ken Rueegsegger wrote: > Module reference counting for shash is incorrect: when > a new shash transformation is created the refcount is not > increased as it should. > > Signed-off-by: Adrian-Ken Rueegsegger Applied to crypto-2.6. Thanks Adrian!

Re: [PATCH] AMCC Crypto4xx Device Driver v6

2009-02-04 Thread Herbert Xu
On Wed, Jan 28, 2009 at 02:53:05PM -0800, James Hsiao wrote: > This patch adds support for AMCC ppc4xx security device driver. This is the > initial release that includes the driver framework with AES and SHA1 > algorithms > support. > The remaining algorithms will be released in the near future.

Re: [PATCH] crypto: Add myself as the maintainer for the CPRNG

2009-02-04 Thread Herbert Xu
On Wed, Jan 28, 2009 at 10:28:52AM -0500, Neil Horman wrote: > > Add myself as the maintainer for the CPRNG. Herbert shouldn't deal with it > alone if (when?) it breaks :) > > Signed-off-by: Neil Horman Patch applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>H

Re: [PATCH] crypto: Force panic on continuous CPRNG test failure when in FIPS mode

2009-02-04 Thread Herbert Xu
On Wed, Jan 28, 2009 at 07:58:48AM -0500, Neil Horman wrote: > > FIPS 140-2 specifies that all access to various cryptographic modules be > prevented in the event that any of the provided self tests fail on the various > implemented algorithms. We already panic when any of the test in testmgr.c >

zeroing tfms in crypto_free_tfm()

2009-02-04 Thread Geert Uytterhoeven
A long time ago (in 2.6.9 and 2.4.28), crypto_free_tfm() started zeroing "alg->cra_ctxsize" bytes before freeing a crypto_tfm: | commit 94ab49d18f69a816561ae199e05daab709ba912e (from full-history-linux) | Author: David S. Miller | Date: Tue Sep 14 08:21:40 2004 -0700 | | [CRYPTO]: Zero out