Re: [PATCH] crypto: force reset of cprng on allocation

2009-01-27 Thread Herbert Xu
On Fri, Jan 23, 2009 at 11:50:27AM -0500, Neil Horman wrote: > pseudo RNGs provide predictable outputs based on input parateters {key, V, > DT}, > the idea behind them is that only the user should know what the inputs are. > While its nice to have default known values for testing purposes, it seem

Re: [PATCH] crypto: Force panic on continuous CPRNG test failure when in FIPS mode

2009-01-27 Thread Herbert Xu
On Fri, Jan 23, 2009 at 10:58:17AM -0500, Neil Horman wrote: > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > index 0fac8ff..7eef5be 100644 > --- a/crypto/ansi_cprng.c > +++ b/crypto/ansi_cprng.c > @@ -132,10 +132,20 @@ static int _get_more_prng_bytes(struct prng_context > *ctx) >

Re: [PATCH] AMCC Crypto4xx Device Driver v5

2009-01-27 Thread Herbert Xu
On Mon, Jan 12, 2009 at 11:30:50AM -0800, James Hsiao wrote: > This is the 5th submission of AMCC's security driver. > - remove aad support in build pd function, since we didn't release any > algorithm that use aead yet. > > - changed some hardcode value to #defines > > - changed local_irq_disabl

Re: crypto: sha-s390 - Switch to shash

2009-01-27 Thread Herbert Xu
On Mon, Jan 19, 2009 at 09:55:17AM +1100, Herbert Xu wrote: > > Could you let me if this patch breaks s390? > > commit 0fe7dddf02811152d7e58747bfe419ec0f43ea4e > Author: Herbert Xu > Date: Sun Jan 18 20:33:33 2009 +1100 > > crypto: sha-s390 - Switch to shash > > This patch conver

Re: [RFC] per-CPU cryptd thread implementation based on workqueue

2009-01-27 Thread Herbert Xu
On Fri, Jan 23, 2009 at 11:07:06PM -0800, Andrew Morton wrote: > > > +int cryptd_enqueue_request(struct cryptd_queue *queue, > > + struct crypto_async_request *request) > > +{ > > + int cpu, err, queued; > > + struct cryptd_cpu_queue *cpu_queue; > > + > > + cpu = get_cpu(

Re: IPSec AH hardware offload

2009-01-27 Thread Herbert Xu
Jamie Iles wrote: > > I'm currently developing a driver for a hardware crypto offload engine that is > capable of offloading both ESP and AH in IPSec. I've noticed that none of the > crypto drivers in 2.6.28 do offload for ahash and that the netkey AH > implementation both use synchronous hashes.

Re: Linux 2.6.28 and AEAD initialization

2009-01-27 Thread Herbert Xu
On Wed, Jan 28, 2009 at 01:18:57AM +0100, Andreas Steffen wrote: > Hi Herbert, > > your patch fixes the initialization problem! Thanks for testing! I'll push this fix out. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/

Re: Clarification of allowed context for crypto routines

2009-01-27 Thread Herbert Xu
On Tue, Jan 27, 2009 at 09:01:13PM +0300, Andrey Borzenkov wrote: > > - all usage is kmap_atomic; which implies it should be technically safe > (not advisable) to use in interrupt context as well kmap_atomic has limited slots, we currently use two slots for process context and two slots for soft

Re: Linux 2.6.28 and AEAD initialization

2009-01-27 Thread Andreas Steffen
Hi Herbert, your patch fixes the initialization problem! Thanks Andreas Herbert Xu wrote: > On Wed, Jan 21, 2009 at 02:29:48AM +, Andreas Steffen wrote: >> Because of type=nivaead >> >> if (alg->cra_type == &crypto_aead_type) >> return alg; >> >> crypto_lookup_aead() does not re

Re: Clarification of allowed context for crypto routines

2009-01-27 Thread Andrey Borzenkov
On 24 января 2009 12:32:45 Herbert Xu wrote: > Andrey Borzenkov wrote: > > On 24 января 2009 01:31:50 Herbert Xu wrote: > >> 2) The highmem primitives we use are currently softirq only. We > >> could make them work for hardirq as well, but because of 1) we > >> didn't. > > > > Could you point to