Re: Does ESP support 64 bit sequence numbering for authentication hash ?

2009-01-14 Thread Herbert Xu
Dean Jenkins wrote: > > Does ESP support 64 bit sequence numbering for use with the > authentication HMAC ? We don't support 64-bit sequence numbers yet. If you look at struct xfrm_replay_state which is where we store the sequence number internally you'll find that it uses u32s. Patches for 64

Crypto Fixes for 2.6.29

2009-01-14 Thread Herbert Xu
Hi Linus: This push fixes a crash in authenc that may occur if null encryption is used (a rare configuration). Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Herbert Xu (1): cry

Re: [RFC PATCH crypto -v3 2/2] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-14 Thread Herbert Xu
On Wed, Jan 14, 2009 at 03:44:12PM +0800, Huang Ying wrote: > This is not intented to be merged, just for reviewing. If no other > issues, I will pre-assemble AES-NI instructions in aesni-intel_asm.S, > because they are not supported by some binutils until now. Looks good, thanks! -- Visit Opensw

Re: [RFC PATCH crypto -v3 1/2] AES-NI: Add support to access underlying blkcipher under cryptd ablkcipher

2009-01-14 Thread Herbert Xu
On Wed, Jan 14, 2009 at 03:44:06PM +0800, Huang Ying wrote: > cryptd_alloc_ablkcipher() will allocate a cryptd-ed ablkcipher for > specified algorithm name. The new allocated one is guaranteed to be > cryptd-ed ablkcipher, so the blkcipher underlying can be gotten via > cryptd_ablkcipher_child(). >

Re: [PATCH] crypto: compress - Add pcomp interface

2009-01-14 Thread Herbert Xu
On Wed, Jan 14, 2009 at 04:01:34PM +0100, Geert Uytterhoeven wrote: > > It's used by the pr_*() macros in . > > Since commit d091c2f58ba32029495a933b721e8e02fbd12caa ("Add 'pr_fmt()' format > modifier to pr_xyz macros."), this is the new way to have a common prefix in > all printed output. But yo

Re: [PATCH] crypto: compress - Add pcomp interface

2009-01-14 Thread Jaswinder Singh Rajput
On Wed, Jan 14, 2009 at 10:24 PM, Geert Uytterhoeven wrote: > On Wed, 14 Jan 2009, Jaswinder Singh Rajput wrote: >> On Tue, Jan 13, 2009 at 9:29 PM, Geert Uytterhoeven >> wrote: >> > +static inline struct pcomp_alg *crypto_pcomp_alg(struct crypto_pcomp *tfm) >> > +{ >> > + return __crypto_p

Re: [PATCH] crypto: compress - Add pcomp interface

2009-01-14 Thread Geert Uytterhoeven
On Wed, 14 Jan 2009, Jaswinder Singh Rajput wrote: > On Tue, Jan 13, 2009 at 9:29 PM, Geert Uytterhoeven > wrote: > > +static inline struct pcomp_alg *crypto_pcomp_alg(struct crypto_pcomp *tfm) > > +{ > > + return __crypto_pcomp_alg(crypto_pcomp_tfm(tfm)->__crt_alg); > > +} > > + > > +static

Re: [PATCH] crypto: compress - Add pcomp interface

2009-01-14 Thread Jaswinder Singh Rajput
On Tue, Jan 13, 2009 at 9:29 PM, Geert Uytterhoeven wrote: > +static inline struct pcomp_alg *crypto_pcomp_alg(struct crypto_pcomp *tfm) > +{ > + return __crypto_pcomp_alg(crypto_pcomp_tfm(tfm)->__crt_alg); > +} > + > +static inline int crypto_pcomp_setup(struct crypto_pcomp *tfm, > +

Re: [PATCH] crypto: compress - Add pcomp interface

2009-01-14 Thread Geert Uytterhoeven
Hi Herbert, On Wed, 14 Jan 2009, Herbert Xu wrote: > On Tue, Jan 13, 2009 at 04:59:40PM +0100, Geert Uytterhoeven wrote: > > The current "comp" crypto interface supports one-shot (de)compression only, > > i.e. the whole data buffer to be (de)compressed must be passed at once, and > > the w

Does ESP support 64 bit sequence numbering for authentication hash ?

2009-01-14 Thread Dean Jenkins
Hi, Does ESP support 64 bit sequence numbering for use with the authentication HMAC ? I've looked at struct aead_givcrypt_request and it has a u64 seq member. Does ESP populate this with a 64 bit sequence number ? If 32 bit sequence numbering negotiated then how does the HMAC routine know that i

Re: Use cryptd(%s) as cryptd-ed algorithm name instead of %s

2009-01-14 Thread Herbert Xu
On Wed, Jan 14, 2009 at 03:01:51PM +0800, Huang Ying wrote: > > Current cryptd works well for AES-NI implementation. But how about > somebody want cryptd(cbc(aes)), and don't care about the driver. That's not an issue, if the user wants then all he has to do is create cryptd(cbc(aes)) (how that i