Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-01-12 Thread Herbert Xu
On Mon, Nov 17, 2008 at 03:31:42PM -0800, Shasi Pulijala wrote: > > This patch v8 includes the code that prevents synchronous calls from freeing > data when request completion is interrupted, while the data may still be > accessed by the crypto code in parallel. > From: Shasi Pulijala > > > S

Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-12 Thread Herbert Xu
On Tue, Jan 13, 2009 at 10:49:07AM +0800, Huang Ying wrote: > > I can set req->data in xx_encrypt() to my original request to solve this > issue. Except that, does this solution work? Yes it would work provided that you save the original data somewhere in your context (and then restore it of cours

Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-12 Thread Huang Ying
On Tue, 2009-01-13 at 10:39 +0800, Herbert Xu wrote: > On Tue, Jan 13, 2009 at 10:34:13AM +0800, Huang Ying wrote: > > > > static void ablk_complete(struct crypto_async_request *req, int err) > > { > > struct ablkcipher_request *ablk_req = ablkcipher_request_cast(req); > > struct a

Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-12 Thread Herbert Xu
On Tue, Jan 13, 2009 at 10:34:13AM +0800, Huang Ying wrote: > > static void ablk_complete(struct crypto_async_request *req, int err) > { > struct ablkcipher_request *ablk_req = ablkcipher_request_cast(req); > struct async_aes_req_ctx *req_ctx = > ablk_aes_req_ctx(ab

Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-12 Thread Huang Ying
On Mon, 2009-01-12 at 18:43 +0800, Herbert Xu wrote: > On Mon, Jan 12, 2009 at 02:55:10PM +0800, Huang Ying wrote: > > > > I use a "shell" cbc(aes) algorithm which chooses between > > cryptd(__cbc-aes-aesni) and __cbc-aes-aesni according to context. But > > the struct ablkcipher_request passed in c

Re: kernel BUG at crypto/scatterwalk.c:37! when using modified tcrypt for HMAC testing

2009-01-12 Thread Herbert Xu
Dean Jenkins wrote: > > I'm using a 2.6.27.4 kernel on an armv5te platform. > > I hit a BUG() at crypto/scatterwalk.c:37 that indicates that the scatterlist > length is zero. > > I've traced this back to crypto/authenc.c function crypto_authenc_genicv()... Does this patch fix it? commit 700aa

kernel BUG at crypto/scatterwalk.c:37! when using modified tcrypt for HMAC testing

2009-01-12 Thread Dean Jenkins
Hi, I'm trying to test AEAD based HMAC (sha1-96) with NULL encryption using a modified tcrypt module. I'm using a 2.6.27.4 kernel on an armv5te platform. I hit a BUG() at crypto/scatterwalk.c:37 that indicates that the scatterlist length is zero. I've traced this back to crypto/authenc.c func

Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

2009-01-12 Thread Herbert Xu
On Mon, Jan 12, 2009 at 02:55:10PM +0800, Huang Ying wrote: > > I use a "shell" cbc(aes) algorithm which chooses between > cryptd(__cbc-aes-aesni) and __cbc-aes-aesni according to context. But > the struct ablkcipher_request passed in can not be used for cryptd(*). > This can be resolved by allocat