Re: [PATCH v4] crypto: des3_ede: permit weak keys unless REQ_WEAK_KEY set

2008-12-16 Thread Herbert Xu
On Mon, Dec 08, 2008 at 10:41:41AM -0500, Jarod Wilson wrote: > While its a slightly insane to bypass the key1 == key2 || > key2 == key3 check in triple-des, since it reduces it to the > same strength as des, some folks do need to do this from time > to time for backwards compatibility with des. >

Re: [PATCH 0/2 v4] Switch remaining algorithms to shash

2008-12-16 Thread Herbert Xu
On Sun, Dec 07, 2008 at 11:17:27PM +0100, Adrian-Ken Rueegsegger wrote: > This resend contains the fixed up sha512 patches to switch the last > remaining algorithm to shash. > > The first patch is now correct also in the case of preemption. The > second patch remains unchanged. Both applied. Tha

Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

2008-12-16 Thread Herbert Xu
On Wed, Dec 17, 2008 at 11:33:39AM +0800, Huang Ying wrote: > > - Now an AES core block algorithm is implemented with AES-NI as > CRYPTO_ALG_TYPE_CIPHER, which can benefit all modes (CBC, LRW, etc). But > because it seems that there is no asynchronous interface for > CRYPTO_ALG_TYPE_CIPHER, the AE

Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

2008-12-16 Thread Huang Ying
On Wed, 2008-12-17 at 09:26 +0800, Herbert Xu wrote: > Huang Ying wrote: > > > > f. if TS is clear, then use x86_64 implementation. Otherwise if > > user-space has touched the FPU, we save the state, if not then simply > > clear TS. > > Well I'd rather avoid using the x86_64 implementation ever b

Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

2008-12-16 Thread Herbert Xu
Huang Ying wrote: > > f. if TS is clear, then use x86_64 implementation. Otherwise if > user-space has touched the FPU, we save the state, if not then simply > clear TS. Well I'd rather avoid using the x86_64 implementation ever because unless the chip guys have really screwed up we should be loo

Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

2008-12-16 Thread Huang Ying
On Wed, 2008-12-17 at 07:31 +0800, Herbert Xu wrote: > On Mon, Dec 15, 2008 at 11:38:01PM +1100, Herbert Xu wrote: > > On Mon, Dec 15, 2008 at 04:21:06PM +1100, Herbert Xu wrote: > > > > > > > a. Do not touch SSE state in soft_irq > > > > b. Disable/restore soft_irq in kernel_fpu_begin/kernel_fpu_e

Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions

2008-12-16 Thread Herbert Xu
On Mon, Dec 15, 2008 at 11:38:01PM +1100, Herbert Xu wrote: > On Mon, Dec 15, 2008 at 04:21:06PM +1100, Herbert Xu wrote: > > > > > a. Do not touch SSE state in soft_irq > > > b. Disable/restore soft_irq in kernel_fpu_begin/kernel_fpu_end > > > c. Use a per-CPU data structure to save kernel FPU sta