Re: [PATCH] AMCC Crypto4xx Device Driver v4]

On Friday 05 December 2008, Kim Phillips wrote: > > diff --git a/arch/powerpc/boot/dts/canyonlands.dts > > b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644 > > --- a/arch/powerpc/boot/dts/canyonlands.dts > > +++ b/arch/powerpc/boot/dts/canyonlands.dts > > @@ -116,6 +116,13 @@ >

Re: [PATCH] AMCC Crypto4xx Device Driver v4]

On Tue, 02 Dec 2008 14:17:12 -0800 James Hsiao <[EMAIL PROTECTED]> wrote: > Hi, > > This patch add canyonlands support. > > Few performance optimizations: > Redesigned the crypto4xx_build_pd(), which now calculate number of > scatter and gather descriptors need before taking them. Instead take

[PATCH] crypto: sha512 - Switch to shash

This patch changes sha512 and sha384 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/sha512_generic.c | 112 +-- 2 files changed, 60 insertions(+), 54 deletions(-) dif

[PATCH 0/1] Resend correct sha512 shash patch

I am resending patch 2 of the series since I accidentially submitted the sha512 shash patch which does not contain the needed Kconfig changes. My apologies for the mixup, Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED]

[PATCH 4/4 v3] crypto: michael_mic - Switch to shash

This patch changes michael_mic to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/michael_mic.c | 72 - 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/

[PATCH 3/4 v3] crypto: wp512 - Switch to shash

This patch changes wp512, wp384 and wp256 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/wp512.c | 121 ++-- 2 files changed, 66 insertions(+), 57 deletions(-) diff --

[PATCH 2/4 v3] crypto: sha512 - Switch to shash

This patch changes sha512 and sha384 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/sha512_generic.c | 112 +-- 1 files changed, 59 insertions(+), 53 deletions(-) diff --git a/crypto/sha512_generic.c b

[PATCH 1/4 v3] crypto: sha512 - Move message schedule W[80] to static percpu area

The message schedule W (u64[80]) is too big for the stack. In order for this algorithm to be used with shash it is moved to a static percpu area. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/sha512_generic.c | 17 + 1 files changed, 9 insertions(+), 8 del

[PATCH 0/4 v3] Switch remaining algorithms to shash

This series contains the fixed up patches to convert the remaining hash algorithms to use shash. The first patch now moves the message schedule W from struct sha512_ctx to a static percpu area. The sha512 patch is adjusted to accomodate the changes from patch 1 while the last two patches remain u

Re: [PATCH 1/4 v2] crypto: sha512 - Remove W (message schedule) from struct sha512_ctx

Herbert Xu wrote: > On Thu, Dec 04, 2008 at 10:32:07AM +0100, Adrian-Ken Rueegsegger wrote: >> static void >> -sha512_transform(u64 *state, u64 *W, const u8 *input) >> +sha512_transform(u64 *state, const u8 *input) >> { >> u64 a, b, c, d, e, f, g, h, t1, t2; >> - >> +u64 W[80]; > > This

Re: [PATCH 1/4 v2] crypto: sha512 - Remove W (message schedule) from struct sha512_ctx

On Thu, Dec 04, 2008 at 10:32:07AM +0100, Adrian-Ken Rueegsegger wrote: > > static void > -sha512_transform(u64 *state, u64 *W, const u8 *input) > +sha512_transform(u64 *state, const u8 *input) > { > u64 a, b, c, d, e, f, g, h, t1, t2; > - > + u64 W[80]; This is too big for the stack.

[PATCH 4/4 v2] crypto: michael_mic - Switch to shash

This patch changes michael_mic to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/michael_mic.c | 72 - 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/

[PATCH 3/4 v2] crypto: wp512 - Switch to shash

This patch changes wp512, wp384 and wp256 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/wp512.c | 121 ++-- 2 files changed, 66 insertions(+), 57 deletions(-) diff --

[PATCH 2/4 v2] crypto: sha512 - Switch to shash

This patch changes sha512 and sha384 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/Kconfig |2 +- crypto/sha512_generic.c | 107 -- 2 files changed, 57 insertions(+), 52 deletions(-) diff

[PATCH 1/4 v2] crypto: sha512 - Remove W (message schedule) from struct sha512_ctx

The message schedule W[80] is calculated anew when sha512_transform is executed. Therefore it is local to that function and does not need to be defined in struct sha512_ctx. Note: the sha256 algorithm already does it this way. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/s

[PATCH 0/4 v2] Switch remaining algorithms to shash

This series contains the fixed up patches to convert the remaining hash algorithms to use the new shash interface. The first patch is left unchanged and removes the message schedule W from struct sha512_ctx. The last three patches now contain the needed Kconfig dependencies. Adrian -- To unsubsc

Re: [PATCH 4/4][RFC] crypto: michael_mic - Switch to shash

Herbert Xu wrote: > On Thu, Dec 04, 2008 at 01:18:12AM +0100, Adrian-Ken Rueegsegger wrote: >> struct michael_mic_ctx { >> +u32 l, r; >> +}; >> + >> +struct michael_mic_desc_ctx { >> u8 pending[4]; >> size_t pending_len; >> >> u32 l, r; >> }; > > Any reason why you left them

Re: [PATCH 0/4] Switch remaining algorithms to shash

On Thu, Dec 04, 2008 at 08:55:57AM +0100, Adrian-Ken Rueegsegger wrote: > > If I read the code correctly l and r are not read-only, e.g. in > michael_update there are multiple assignments to mctx->l and mctx->r. > That's the reason why I left them in the desc context. I see. In that case your pat