Re: [PATCH 0/4] Switch remaining algorithms to shash

2008-12-03 Thread Adrian-Ken Rueegsegger
Hello Herbert, Herbert Xu wrote: > On Thu, Dec 04, 2008 at 01:18:08AM +0100, Adrian-Ken Rueegsegger wrote: >> The first patch removes the message schedule W from struct sha512_ctx >> since it gets calculated anew on each execution of sha512_transform. This >> reduces the size of sha512_ctx conside

Re: [PATCH 0/4] Switch remaining algorithms to shash

2008-12-03 Thread Herbert Xu
On Thu, Dec 04, 2008 at 01:18:08AM +0100, Adrian-Ken Rueegsegger wrote: > > The first patch removes the message schedule W from struct sha512_ctx > since it gets calculated anew on each execution of sha512_transform. This > reduces the size of sha512_ctx considerably and will allow it to be > regi

Re: [PATCH 4/4][RFC] crypto: michael_mic - Switch to shash

2008-12-03 Thread Herbert Xu
On Thu, Dec 04, 2008 at 01:18:12AM +0100, Adrian-Ken Rueegsegger wrote: > > struct michael_mic_ctx { > + u32 l, r; > +}; > + > +struct michael_mic_desc_ctx { > u8 pending[4]; > size_t pending_len; > > u32 l, r; > }; Any reason why you left them in the desc context? Cheer

[PATCH 4/4][RFC] crypto: michael_mic - Switch to shash

2008-12-03 Thread Adrian-Ken Rueegsegger
This patch changes michael_mic to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/michael_mic.c | 72 - 1 files changed, 41 insertions(+), 31 deletions(-) diff --git a/crypto/michael_mic.c b/crypto/mi

[PATCH 3/4] crypto: wp512 - Switch to shash

2008-12-03 Thread Adrian-Ken Rueegsegger
This patch changes wp512, wp384 and wp256 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/wp512.c | 121 ++-- 1 files changed, 65 insertions(+), 56 deletions(-) diff --git a/crypto/wp512.c b/cry

[PATCH 2/4] crypto: sha512 - Switch to shash

2008-12-03 Thread Adrian-Ken Rueegsegger
This patch changes sha512 and sha384 to the new shash interface. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/sha512_generic.c | 107 -- 1 files changed, 56 insertions(+), 51 deletions(-) diff --git a/crypto/sha512_generic.c b/

[PATCH 1/4] crypto: sha512 - Remove W (message schedule) from struct sha512_ctx

2008-12-03 Thread Adrian-Ken Rueegsegger
The message schedule W[80] is calculated anew when sha512_transform is executed. Therefore it is local to that function and does not need to be defined in struct sha512_ctx. Note: the sha256 algorithm already does it this way. Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- crypto/s

[PATCH 0/4] Switch remaining algorithms to shash

2008-12-03 Thread Adrian-Ken Rueegsegger
This series converts the remaining hash algorithms to use the new shash interface. The first patch removes the message schedule W from struct sha512_ctx since it gets calculated anew on each execution of sha512_transform. This reduces the size of sha512_ctx considerably and will allow it to be reg

Re: [PATCH] crypto: talitos - Fix modpost warning

2008-12-03 Thread Kumar Gala
On Dec 3, 2008, at 8:52 AM, Kumar Gala wrote: On Dec 3, 2008, at 6:06 AM, Herbert Xu wrote: On Tue, Dec 02, 2008 at 10:29:16PM -0600, Kumar Gala wrote: Removed __devexit from talitos_remove() since its also called from talitos_probe(). WARNING: vmlinux.o(.text+0x28a008): Section mismatch i

Re: [PATCH] crypto: talitos - Fix modpost warning

2008-12-03 Thread Kumar Gala
On Dec 3, 2008, at 6:06 AM, Herbert Xu wrote: On Tue, Dec 02, 2008 at 10:29:16PM -0600, Kumar Gala wrote: Removed __devexit from talitos_remove() since its also called from talitos_probe(). WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() t

Re: [PATCH] crypto: talitos - Fix modpost warning

2008-12-03 Thread Herbert Xu
On Tue, Dec 02, 2008 at 10:29:16PM -0600, Kumar Gala wrote: > Removed __devexit from talitos_remove() since its also called from > talitos_probe(). > > WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the > function talitos_probe() to the function .devexit.text:talitos_remov

Re: [PATCH 5/5] crypto: michael_mic - Switch to shash

2008-12-03 Thread Herbert Xu
On Tue, Dec 02, 2008 at 11:38:34PM +0100, Adrian-Ken Rueegsegger wrote: > This patch changes michael_mic to the new shash interface. > > Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> I've applied patches 1-4. > -static int michael_setkey(struct crypto_tfm *tfm, const u8 *key, > +sta