Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > > fix warning in drivers/net/sky2.c > > fix warning in net/sunrpc/svcauth_unix.c > > fix warning in security/selinux/netnode.c > > fix warning in net/packet/af_packet.c > > fix warning in net/rfkill/rfkill.c > > Not applied. Changi

Re: [warnings] 37 warning fixes in networking related files

2008-11-25 Thread David Miller
I already applied these patches, see my reply in that thread. I was saying to submit these (individually, please!) next time with netdev CC:'d. Posting a ton all at once is pointless, they all get logged to patchwork as one big blog and I cannot annotate them individually and give you proper fee

[warnings] 37 warning fixes in networking related files

2008-11-25 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > Date: Tue, 25 Nov 2008 18:14:38 +0100 > > > btw, on a related note, there's a couple of networking related warning > > fixes/annotations i've got queued up. > > I see these now, but they would get properly logg

Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 18:14:38 +0100 > fix warning in drivers/net/s2io.c > fix warnings in drivers/net/niu.c > fix warning in drivers/net/niu.c > fix warning in drivers/net/qla3xxx.c > fix warning in net/sunrpc/xprtrdma/svc_rdma_transport.

Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 18:14:38 +0100 > btw, on a related note, there's a couple of networking related warning > fixes/annotations i've got queued up. I see these now, but they would get properly logged and tracked at: http://patchwork.ozlabs.org/pr

Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread Patrick McHardy
Ingo Molnar wrote: btw, on a related note, there's a couple of networking related warning fixes/annotations i've got queued up. I've got 37 commits of that nature in the tip/warnings/* topic branches: [...] They are done mainly so that we can notice the warnings we introduce via any of the

Re: [PATCH/RFC 0/4] Partial decompression API (was: Re: [patch 1/3] crypto: Add a zlib crypto module)

2008-11-25 Thread Geert Uytterhoeven
On Tue, 25 Nov 2008, Herbert Xu wrote: > On Mon, Nov 24, 2008 at 05:11:42PM +0100, Geert Uytterhoeven wrote: > > As pointed out in patch [1/4], some underlying (de)compression > > implementations > > do not support partial (de)compression. This is the case for e.g. LZO, > > which > > is already

Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > On Tue, Nov 25, 2008 at 09:58:21AM +0100, Ingo Molnar wrote: > > > > Noticed the bug below while running our -Werror x86 randconfig build > > tests against tip/master. Please double check my control flow > > analysis. > > Good catch, I'll apply this p

Re: [PATCH/RFC 1/4] crypto: Add partial decompression support to the CRYPTO API

2008-11-25 Thread Herbert Xu
On Mon, Nov 24, 2008 at 05:12:37PM +0100, Geert Uytterhoeven wrote: > To solve this, add the following operations that support partial > (de)compression: > - crypto_compress_{init,update,final}() for compression, > - crypto_decompress_{init,update,final}() for decompression. Probably best to p

Re: [PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread Herbert Xu
On Tue, Nov 25, 2008 at 09:58:21AM +0100, Ingo Molnar wrote: > > Noticed the bug below while running our -Werror x86 randconfig build > tests against tip/master. Please double check my control flow > analysis. Good catch, I'll apply this patch. Thanks Ingo! -- Visit Openswan at http://www.open

Re: [HIFN] Use softirq kernel mapping in bh context.

2008-11-25 Thread Herbert Xu
On Mon, Nov 24, 2008 at 05:52:40PM +0300, Evgeniy Polyakov wrote: > Use KM_SOFTIRQ instead of KM_IRQ in tasklet context. > Added bug_on on input no-page condition. > > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> Patch applied. Thanks Evgeniy! -- Visit Openswan at http://www.openswan.org

Re: [PATCH/RFC 0/4] Partial decompression API (was: Re: [patch 1/3] crypto: Add a zlib crypto module)

2008-11-25 Thread Herbert Xu
Thanks for the patches! On Mon, Nov 24, 2008 at 05:11:42PM +0100, Geert Uytterhoeven wrote: > > As pointed out in patch [1/4], some underlying (de)compression implementations > do not support partial (de)compression. This is the case for e.g. LZO, which > is already supported by a crypto module.

[PATCH] crypto: fix error flow of crypto/testmgr.c:test_comp()

2008-11-25 Thread Ingo Molnar
Noticed the bug below while running our -Werror x86 randconfig build tests against tip/master. Please double check my control flow analysis. Ingo --> >From e5c3b90a18b73d593bba2a3f927a79469b6218d7 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <[EMAIL PROTECTED]> Date: Tue, 25 Nov