Re: [PATCH] ansi_cprng: zero out key data on exit

2008-11-24 Thread Neil Horman
On Mon, Nov 24, 2008 at 09:22:07PM +0800, Herbert Xu wrote: > On Fri, Nov 14, 2008 at 03:55:36PM -0500, Neil Horman wrote: > > > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > > index 72db0fd..e6ad373 100644 > > --- a/crypto/ansi_cprng.c > > +++ b/crypto/ansi_cprng.c > > @@ -266,6 +266,

[PATCH/RFC 4/4] squashfs: Make SquashFS 4 use the new "zlib" crypto module

2008-11-24 Thread Geert Uytterhoeven
Modify SquashFS 4 to use the new "zlib" crypto module as a proof-of-concept for the partial decompression CRYPTO API enhancements. Note: Patch against squashfs-2.6.git, as SquashFS is not yet in mainline Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- Kconfig |3 +

[PATCH/RFC 3/4] crypto: Add a test for the "zlib" crypto module

2008-11-24 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- tcrypt.c |6 +++- testmgr.c | 15 +++ testmgr.h | 81 ++ 3 files changed, 101 insertions(+), 1 deletion(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 28

[PATCH/RFC 2/4] crypto: Add a "zlib" crypto module

2008-11-24 Thread Geert Uytterhoeven
Add a "zlib" crypto module, which differs from the existing "deflate" crypto module in the following aspects: - Support for the new partial (de)compression API has been added, - The (de)compression parameters have been changed to accomodate SquashFS ("zlib" format with 15 window bits instea

[PATCH/RFC 1/4] crypto: Add partial decompression support to the CRYPTO API

2008-11-24 Thread Geert Uytterhoeven
The current CRYPTO API supports one-shot (de)compression only, i.e. the whole data buffer to be (de)compressed must be passed at once, and the whole (de)compressed data buffer will be received at once. In several use-cases (e.g. compressed file systems that store files in big compressed blocks), th

[PATCH/RFC 0/4] Partial decompression API (was: Re: [patch 1/3] crypto: Add a zlib crypto module)

2008-11-24 Thread Geert Uytterhoeven
On Sat, 30 Aug 2008, Herbert Xu wrote: > On Fri, Aug 29, 2008 at 01:41:59PM +, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > Add a (de)compression module for the "zlib" format using the crypto API. > > I think we can safely conclude that our current compre

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Evgeniy Polyakov
On Mon, Nov 24, 2008 at 10:34:27PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Mon, Nov 24, 2008 at 05:23:22PM +0300, Evgeniy Polyakov wrote: > > > > Weird. patch/diff and hands all messed up. In the version which was > > tested there is no that changes, so just drop it. > > OK I've applied

[HIFN] Use softirq kernel mapping in bh context.

2008-11-24 Thread Evgeniy Polyakov
Use KM_SOFTIRQ instead of KM_IRQ in tasklet context. Added bug_on on input no-page condition. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c index 26384e7..6e9b39c 100644 --- a/drivers/crypto/hifn_795x.c +++ b/drivers/crypt

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Herbert Xu
On Mon, Nov 24, 2008 at 05:23:22PM +0300, Evgeniy Polyakov wrote: > > Weird. patch/diff and hands all messed up. In the version which was > tested there is no that changes, so just drop it. OK I've applied everything bar the first two and pushed it out. Please let me know if there's anything broke

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Evgeniy Polyakov
Hi. On Mon, Nov 24, 2008 at 10:09:34PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > > It seems the previous patch got mixed up, this is what I have in > > my old tree (just for reference, I don't know whether Evgeniy made > > any changes): > > Thanks Patrick. Evgeniy, please let us know if thi

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Herbert Xu
On Mon, Nov 24, 2008 at 03:00:45PM +0100, Patrick McHardy wrote: > > It seems the previous patch got mixed up, this is what I have in > my old tree (just for reference, I don't know whether Evgeniy made > any changes): Thanks Patrick. Evgeniy, please let us know if this move is still needed or no

Re: [HIFN] Bugfix series.

2008-11-24 Thread Herbert Xu
On Wed, Nov 19, 2008 at 02:03:25PM +, Evgeniy Polyakov wrote: > > This series contains HIFN driver fixes based on Patrick McHardy's work > and additional queue management fix. This set also bumps HIFN performance > almost two times compared to old code. Please apply. All applied except for th

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Patrick McHardy
Herbert Xu wrote: On Wed, Nov 19, 2008 at 02:03:27PM +, Evgeniy Polyakov wrote: From: Patrick McHardy <[EMAIL PROTECTED]> The descriptors need to be invalidated after processing for ring cleanup to work properly and to avoid using an old destination descriptor when the src and cmd descripto

Re: [PATCH] Have HW invalidate src and dest descriptors after processing

2008-11-24 Thread Herbert Xu
On Wed, Nov 19, 2008 at 02:03:27PM +, Evgeniy Polyakov wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > > The descriptors need to be invalidated after processing for ring > cleanup to work properly and to avoid using an old destination > descriptor when the src and cmd descriptors are alre

Re: [PATCH] ansi_cprng: zero out key data on exit

2008-11-24 Thread Herbert Xu
On Fri, Nov 14, 2008 at 03:55:36PM -0500, Neil Horman wrote: > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > index 72db0fd..e6ad373 100644 > --- a/crypto/ansi_cprng.c > +++ b/crypto/ansi_cprng.c > @@ -266,6 +266,7 @@ done: > static void free_prng_context(struct prng_context *ctx) > {

Re: [PATCH] crypto: ansi_cprng: fix inverted DT increment routine

2008-11-24 Thread Herbert Xu
On Thu, Nov 13, 2008 at 01:44:31PM -0500, Neil Horman wrote: > On Thu, Nov 13, 2008 at 11:36:11AM -0500, Jarod Wilson wrote: > > The ANSI X9.31 PRNG docs aren't particularly clear on how to increment DT, > > but empirical testing shows we're incrementing from the wrong end. A 10,000 > > iteration M