Re: [PATCH] AMCC Crypto4xx Device Driver v3]

2008-11-13 Thread Herbert Xu
On Thu, Nov 13, 2008 at 08:28:45AM -0800, James Hsiao wrote: > > Thanks for the review. > Sure I will cc both of you on next submit. I didn't cc linuxppc-dev because > I thought that would be duplicate of work for you. OK, I'm backing this out for now. Thanks, -- Visit Openswan at http://ww

Re: [PATCH] crypto: ansi_cprng: fix inverted DT increment routine

2008-11-13 Thread Neil Horman
On Thu, Nov 13, 2008 at 11:36:11AM -0500, Jarod Wilson wrote: > The ANSI X9.31 PRNG docs aren't particularly clear on how to increment DT, > but empirical testing shows we're incrementing from the wrong end. A 10,000 > iteration Monte Carlo RNG test currently winds up not getting the expected > res

[PATCH] crypto: ansi_cprng: fix inverted DT increment routine

2008-11-13 Thread Jarod Wilson
The ANSI X9.31 PRNG docs aren't particularly clear on how to increment DT, but empirical testing shows we're incrementing from the wrong end. A 10,000 iteration Monte Carlo RNG test currently winds up not getting the expected result. >From http://csrc.nist.gov/groups/STM/cavp/documents/rng/RNGVS.p

Re: [PATCH] AMCC Crypto4xx Device Driver v3]

2008-11-13 Thread Josh Boyer
On Wed, 12 Nov 2008 18:33:59 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: > On Fri, 07 Nov 2008 14:30:47 -0800 > James Hsiao <[EMAIL PROTECTED]> wrote: > > + * Changes: > > + * James Hsiao:10/04/08 > > + * replace global variable lsec_core with data in > > + *

Re: [PATCH linux-next] : Tree for November 12 (libcrc32c)

2008-11-13 Thread Herbert Xu
On Wed, Nov 12, 2008 at 01:01:05PM -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO. > > crypto/built-in.o: In function `crc32c_mod_init': > crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_sha

Re: HIFN driver update.

2008-11-13 Thread Herbert Xu
On Thu, Nov 13, 2008 at 05:04:40PM +0300, Evgeniy Polyakov wrote: > > Not sure if it is possible, since half of the Patrick's patches were > not applied because of already made cleanups. I can split to Patrick's > and 'the rest' though. New features (like variable ring size) will be in > the new pa

Re: HIFN driver update.

2008-11-13 Thread Evgeniy Polyakov
Hi Herbert. On Thu, Nov 13, 2008 at 09:58:54PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > Please send them as separate patches like Patrick's original work. > Having everything mashed together makes maintainence difficult. Not sure if it is possible, since half of the Patrick's patches were n

Re: [PATCH] crypto: ansi_cprng: avoid incorrect extra call to _get_more_prng_bytes

2008-11-13 Thread Herbert Xu
On Wed, Nov 12, 2008 at 03:00:43PM -0500, Jarod Wilson wrote: > > Signed-off-by: Jarod Wilson <[EMAIL PROTECTED]> Patch applied. Thanks everyone! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: HIFN driver update.

2008-11-13 Thread Herbert Xu
Hi Evgeniy: On Tue, Nov 11, 2008 at 10:05:53PM +0300, Evgeniy Polyakov wrote: > Hi. > > Updated version is based on old Patrick McHardy's patches, and contains > several bug fixes from me. Please send them as separate patches like Patrick's original work. Having everything mashed together makes

Re: [PATCH 1/8] crypto/md4.c: use ARRAY_SIZE

2008-11-13 Thread Herbert Xu
On Sun, Nov 09, 2008 at 05:54:15PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > ARRAY_SIZE is more concise to use when the size of an array is divided by > the size of its type or the size of its first element. Applied to cryptodev. Thanks! -- Visit Openswan at http:/

Re: [PATCH] AMCC Crypto4xx Device Driver v3]

2008-11-13 Thread Herbert Xu
On Fri, Nov 07, 2008 at 02:30:47PM -0800, James Hsiao wrote: > Hi Herbert, > > This is patch version 3 of AMCC's security device driver. Applied to cryptodev. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.or