Re: [PATCH] crypto: fix larval lookup

2008-08-18 Thread Herbert Xu
Christian Hohnstaedt <[EMAIL PROTECTED]> wrote: > > crypto_alg_mod_lookup() runs in a timeout (60s) for unknown algos. > > crypto_larval_error() doesn't find the larval and thus doesn't > finish crypto_larval_wait, because > the larval->mask has the CRYPTO_ALG_TESTED bit set, while > crypto_alg_l

Re: [PATCH] ixp4xx_crypto: avoid firmware loading during module initialisation

2008-08-18 Thread Herbert Xu
Christian Hohnstaedt <[EMAIL PROTECTED]> wrote: > By moving the firmware-loading to the transform initialisation, > the driver may be compiled in. > > Notify the user if the firmware does not support AES, or even > no crypto at all. What happens when two tfms are constructed at the same time? Ch

[PATCH] crypto: fix larval lookup

2008-08-18 Thread Christian Hohnstaedt
crypto_alg_mod_lookup() runs in a timeout (60s) for unknown algos. crypto_larval_error() doesn't find the larval and thus doesn't finish crypto_larval_wait, because the larval->mask has the CRYPTO_ALG_TESTED bit set, while crypto_alg_lookup() is called without that bit in the mask and the mask co