Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-16 Thread Kumar Gala
On Jul 16, 2008, at 6:22 PM, Kim Phillips wrote: use GFP_ATOMIC when necessary; use atomic_t when allocating submit_count. why? - k -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

[PATCH 5/6] crypto: talitos - stop leaking memory in error path

2008-07-16 Thread Kim Phillips
free edescriptor when returning error (such as -EAGAIN). Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Acked-by: Lee Nipper <[EMAIL PROTECTED]> --- drivers/crypto/talitos.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto

[PATCH 6/6] crypto: talitos - sparse fix

2008-07-16 Thread Kim Phillips
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/crypto/talitos.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index a81265b..681c15f 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@

[PATCH 4/6] crypto: talitos - fix GFP flag usage

2008-07-16 Thread Kim Phillips
use GFP_ATOMIC when necessary; use atomic_t when allocating submit_count. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Acked-by: Lee Nipper <[EMAIL PROTECTED]> --- drivers/crypto/talitos.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/talitos.c b/

[PATCH 3/6] crypto: talitos - preempt overflow interrupts

2008-07-16 Thread Kim Phillips
add requests pending/submit count to prevent request queue full condition by preempting h/w overflow interrupts in software. We do this due to the delay in the delivery and handling of the channel overflow error interrupt. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Acked-by: Lee Nipper <[EMAI

[PATCH 2/6] crypto: talitos - correct dst != src case handling

2008-07-16 Thread Kim Phillips
From: Lee Nipper <[EMAIL PROTECTED]> Seems that dst == src, but this fixes the logic in case it's not. Signed-off-by: Lee Nipper <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/crypto/talitos.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

[PATCH 1/6] crypto: talitos - remove calls to of_node_put

2008-07-16 Thread Kim Phillips
From: Lee Nipper <[EMAIL PROTECTED]> Remove of_node_put calls since there is no corresponding of_node_get. This patch prevents an exception when talitos is loaded a 2nd time. This sequence: modprobe talitos; rmmod talitos; modprobe talitos causes this message: "WARNING: Bad of_node_put() on /[EMAI

[PATCH] prng; bring prng into better alignment with specification

2008-07-16 Thread Neil Horman
Bring prng into better alignment with specificaion: - Convert to using Generic AES 128 bit cipher - Convert DT to be a non-shifted counter, increasing counter period Signed-off-by: Neil Horman <[EMAIL PROTECTED]> prng.c | 69 +++

[PATCH] prng: fix a few misc bugs in prng

2008-07-16 Thread Neil Horman
Fixing a few misc bugs in prng.c: - Remove prng_key/prng_iv from prng_context (both kept in tfm ptr) - Making _get_more_prng_bytes return meaningful err codes (not just -1/0) Signed-off-by: Neil Horman <[EMAIL PROTECTED]> crypto/prng.c | 26 +- firmware/Ma

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Herbert Xu
On Wed, Jul 16, 2008 at 09:58:41AM -0400, Neil Horman wrote: > > No, this was rather a stream of conscious thing, shifting incrementing numbers > through the buffer, I can certainly make it a simple counter. Yeah I think a simple counter fits the spirit of the specification better. It'll also hav

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Neil Horman
On Wed, Jul 16, 2008 at 09:44:56PM +0800, Herbert Xu wrote: > On Thu, Jul 03, 2008 at 04:21:02PM -0400, Neil Horman wrote: > >> + /* > > +* Now update our DT value > > +*/ > > + for (i=DEFAULT_BLK_SZ-1;i>0;i--) { > > + ctx->DT[i] = ctx->DT[i-1]; > > + } > > + ctx->DT[0] +=

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Herbert Xu
On Thu, Jul 03, 2008 at 04:21:02PM -0400, Neil Horman wrote: >> +/* > + * Now update our DT value > + */ > + for (i=DEFAULT_BLK_SZ-1;i>0;i--) { > + ctx->DT[i] = ctx->DT[i-1]; > + } > + ctx->DT[0] += 1; Is there any reason behind using this algorithm as opposed

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Herbert Xu
On Wed, Jul 16, 2008 at 09:25:40AM -0400, Neil Horman wrote: > > I think I have an irc log somewhere where I thought we discussed this, and > decided that counter mode allowed us a larger period in the random number > stream, but you're correct, simple AES mode is called for in the > specification

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Neil Horman
On Wed, Jul 16, 2008 at 08:45:33PM +0800, Herbert Xu wrote: > On Thu, Jul 03, 2008 at 04:21:02PM -0400, Neil Horman wrote: > > > > + * See http://csrc.nist.gov/groups/STM/cavp/documents/rng/931rngext.pdf > > + * for implementation details > > BTW, any reason why counter mode is used? This document

Re: [PATCH 1/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-16 Thread Herbert Xu
On Thu, Jul 03, 2008 at 04:21:02PM -0400, Neil Horman wrote: > > + * See http://csrc.nist.gov/groups/STM/cavp/documents/rng/931rngext.pdf > + * for implementation details BTW, any reason why counter mode is used? This document specifies simple AES only, with no modes of operations. Thanks, -- Vi

Re: [2.6 patch] properly indent the CRYPTO_RMD* kconfig entries

2008-07-16 Thread Herbert Xu
On Tue, Jul 15, 2008 at 01:05:21PM +0300, Adrian Bunk wrote: > Instead of tabs there were two spaces. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, I'll put these in cryptodev-2.6. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Pa

Change in cryptoloop?

2008-07-16 Thread almafa
Hello! I am using cryptoloop for a while, the volume I have problem with was created at march 24-25 (scripts was created at march 24 so that's why I think) on my Gentoo. It used to work for a while, but now I cannot mount it. I even tried to mount it from a LiveCD, it doesn't help neither. What