Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Sebastian Siewior
* Adrian-Ken Rueegsegger | 2008-06-01 19:16:18 [+0200]: >This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn >allows hmac(rmd160) to be used as authentication mechanism in IPsec >ESP and AH (see RFC 2857). > >Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> >--- > net/xfrm

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Herbert Xu
On Sun, Jun 01, 2008 at 07:16:18PM +0200, Adrian-Ken Rueegsegger wrote: > This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn > allows hmac(rmd160) to be used as authentication mechanism in IPsec > ESP and AH (see RFC 2857). > > Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECT

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Mon, Jun 02, 2008 at 12:43:46AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: > >> Neil Horman wrote: > >>> On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: >

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: Neil Horman wrote: [snip] These tests both seem to fail on my machine. Did you verify that the tes

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 06:09:46PM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > >> Neil Horman wrote: > >>> On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: > Could you document the source of

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Adrian-Ken Rueegsegger
This patch makes HMAC-RIPEMD-160 usable with IPsec/XFRM. Since I have no IPsec test setup the patch has not (yet) been tested with IPsec and is thus marked as RFC. I will put together a test environment which will take some time. In the meantime it would be great if somebody who already has a work

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Adrian-Ken Rueegsegger
This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger <[EMAIL PROTECTED]> --- net/xfrm/xfrm_algo.c |4 ++-- 1 files changed, 2 insertions(+), 2 de

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 03:44:23AM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > I was wondering why you created your o

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Adrian-Ken Rueegsegger
Neil Horman wrote: > On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: >> Neil Horman wrote: >>> On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: Could you document the source of these vectors in the patch description please? >>> Sure, reposting >>> >>> Pa

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 03:10:14AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sat, May 24, 2008 at 10:06:25AM +1000, Herbert Xu wrote: > >> Could you document the source of these vectors in the patch > >> description please? > > > > Sure, reposting > > > > Patch to add check

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-06-01 Thread Neil Horman
On Sun, Jun 01, 2008 at 03:44:23AM +0200, Adrian-Ken Rueegsegger wrote: > Neil Horman wrote: > > On Sat, May 31, 2008 at 08:46:22AM +1000, Herbert Xu wrote: > >> On Fri, May 30, 2008 at 07:26:38PM +0200, Adrian-Ken Rüegsegger wrote: > >>> I was wondering why you created your own test vectors. Would