Re: [HIFN 1/1] Remove duplicated include

2008-05-14 Thread Herbert Xu
On Sat, May 10, 2008 at 11:50:58AM +0400, Evgeniy Polyakov wrote: > Removed duplicated include file . > > Signed-off-by: Huang Weiyi <[EMAIL PROTECTED]> > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> Patch applied. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~

Re: Userspace API proposal was: Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Evgeniy Polyakov
Hi. On Wed, May 14, 2008 at 08:40:43AM -0700, Loc Ho ([EMAIL PROTECTED]) wrote: > Option #2: > 1. Use syscall with algorithm name and its associated parameters > 2. Operation such as encrypt, decrypt, hash, and etc are operated via > another two system call - crypto_read and crypto_write > 3. For

Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Herbert Xu
On Wed, May 14, 2008 at 08:04:22AM -0700, Loc Ho wrote: > Hi, > > Yes... It is intended not to patch OpenSSL twice. Besides the interface > API, the internal does NOT resemble OCF in anyway. But it's exactly the interface that would tie us down to OCF. For instance, we use strings to locate algor

RE: Userspace API proposal was: Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Loc Ho
Hi, We here would like to create an user space interface that can be accepted into Linux CryptoAPI. Therefore, let me summary the current suggestion: Option #1: 1. Use file descriptor named '/dev/crypto' or use syscall 2. Each opened file creates a new 'crypto' context that represents a crypto al

RE: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Loc Ho
Hi, Yes... It is intended not to patch OpenSSL twice. Besides the interface API, the internal does NOT resemble OCF in anyway. -Loc -Original Message- From: Herbert Xu [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 14, 2008 4:03 AM To: Sebastian Siewior Cc: Loc Ho; Shasi Pulijala; linu

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > Hi, > > Patch 1/3 attached. I still can't get the line wrap problem solved. > Therefore it is attached instead inline. All applied. Thanks a lot! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTE

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Wed, May 14, 2008 at 08:40:39PM +0800, Herbert Xu wrote: > > All ahash algorithms should provide a setkey function just like hash. > Digest algorithms should never come down this way. When we convert > digest algorithms over to ahash we should add setkey functions. Oh and for the vast majorit

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > > Please note: > 1. ahash_request has an extra variable 'void *info' for future uses with > KASUMI That's fine. We can change this structure at will. > 2. Any particular reason for removing ahash_nosetkey from function > crypto_init_ahas

Re: Userspace API proposal was: Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Evgeniy Polyakov
On Wed, May 14, 2008 at 01:57:30PM +0200, Sebastian Siewior ([EMAIL PROTECTED]) wrote: > Great. Here a few ideas for a new interface: > - /dev/crypto: > - open file, creates a new ctx which may be one of crypto/hash/... > - set type via ioctl / netlink > - set key / other attributes via ioct

Userspace API proposal was: Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Sebastian Siewior
* Herbert Xu | 2008-05-14 19:03:11 [+0800]: >On Wed, May 14, 2008 at 12:32:24PM +0200, Sebastian Siewior wrote: >> >> >This should add support for OpenSSL. Please note that user of this patch >> >musts patch OpenSSL. The OpenSSL patch can be found in OCF-Linux as this >> >interface uses the same I

Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Evgeniy Polyakov
On Tue, May 13, 2008 at 05:00:58PM -0700, Loc Ho ([EMAIL PROTECTED]) wrote: > Hi Herbert, > > I am re-sending this email as I don't believe it got to the mailing > list. Due to email problem, I am forward this patch on behalf of Shasi > Pulijala who worked on this user space interface for Linux Cr

Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Herbert Xu
On Wed, May 14, 2008 at 12:32:24PM +0200, Sebastian Siewior wrote: > > >This should add support for OpenSSL. Please note that user of this patch > >musts patch OpenSSL. The OpenSSL patch can be found in OCF-Linux as this > >interface uses the same I/O control interface. > So this interface must sta

Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Sebastian Siewior
* Loc Ho | 2008-05-13 17:00:58 [-0700]: >I am re-sending this email as I don't believe it got to the mailing >list. Due to email problem, I am forward this patch on behalf of Shasi >Pulijala who worked on this user space interface for Linux CryptoAPI. If you forward patches, you should put your si

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-14 Thread Sebastian Siewior
* Herbert Xu | 2008-05-06 18:28:15 [+0800]: >Actually this just exposed an ancient bug in hmac. It relied >on the key to be in identity-mapped memory which has never been >guaranteed. huh. Thanks Herbert. I haven't seen this on 32bit machine. >Thanks, Sebastian -- To unsubscribe from this list