Re: [PATCH] [crypto] Make crypto core API modular

2007-12-03 Thread Herbert Xu
On Sun, Dec 02, 2007 at 04:09:50PM +0100, Sebastian Siewior wrote: > * Sebastian Siewior | 2007-12-01 13:19:10 [+0100]: > > >This patch makes the whole crypto API is modular. > Ups, I forgot to put a MODULE_VERSION("GPL") inside of the module. > Herbert, do you nack that patch due to non-sense or

[PATCH 1/2] salsa20_generic: Fix multi-page processing

2007-12-03 Thread Tan Swee Heng
This patch fixes the multi-page processing bug that affects large test vectors (the same bug that previously affected ctr.c). There is an optimization for the case walk.nbytes == nbytes. Also we now use crypto_xor() instead of adhoc XOR routines. Signed-off-by: Tan Swee Heng <[EMAIL PROTECTED]> d

Re: HMAC broken on s390

2007-12-03 Thread Herbert Xu
On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote: > Hi Herbert, > > commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac > on s390 du to the usage of sg_chain(): > > static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents, >

HMAC broken on s390

2007-12-03 Thread Jan Glauber
Hi Herbert, commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac on s390 du to the usage of sg_chain(): static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents, struct scatterlist *sgl) { #ifndef ARCH_HAS_SG_CHAIN BUG();