Re: Moving xor_* functions into common header file

2007-11-19 Thread Herbert Xu
On Tue, Nov 20, 2007 at 02:34:48AM +0800, Tan Swee Heng wrote: > Hi, > > 'grep "static void xor_" crypto/*' shows that cbc.c, ctr.c, pcbc.c and > xcbc.c share similar xor_* functions. It seems a good idea to > encourage code reuse by putting them into a common header (iirc > Evgeniy suggested it

Re: [HIFN 00/03]: RNG support v2

2007-11-19 Thread Michael Buesch
On Monday 19 November 2007 19:25:25 Patrick McHardy wrote: > Michael Buesch wrote: > > On Sunday 18 November 2007 22:32:52 Patrick McHardy wrote: > >> These patches add support for using the HIFN rng. > > > > Acked-by: Michael Buesch <[EMAIL PROTECTED]> > > > > Patrick, can you send this patchset

Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization

2007-11-19 Thread Noriaki TAKAMIYA
Hi, >> Sun, 18 Nov 2007 20:30:16 -0800 >> [Subject: Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, >> 64bit-ization] >> Denys Vlasenko <[EMAIL PROTECTED]> wrote... > > > camellia6: > > > unifies encrypt/decrypt routines for different key lengths. > > > This redu

Moving xor_* functions into common header file

2007-11-19 Thread Tan Swee Heng
Hi, 'grep "static void xor_" crypto/*' shows that cbc.c, ctr.c, pcbc.c and xcbc.c share similar xor_* functions. It seems a good idea to encourage code reuse by putting them into a common header (iirc Evgeniy suggested it when reviewing one of my earlier mail). It will also be useful to me when p

Re: [HIFN 00/03]: RNG support v2

2007-11-19 Thread Patrick McHardy
Michael Buesch wrote: On Sunday 18 November 2007 22:32:52 Patrick McHardy wrote: These patches add support for using the HIFN rng. Acked-by: Michael Buesch <[EMAIL PROTECTED]> Patrick, can you send this patchset to Andrew for inclusion into -mm? I think he already pulls from Herbert's cryp

Re: [HIFN 00/03]: RNG support v2

2007-11-19 Thread Michael Buesch
On Sunday 18 November 2007 22:32:52 Patrick McHardy wrote: > These patches add support for using the HIFN rng. Acked-by: Michael Buesch <[EMAIL PROTECTED]> Patrick, can you send this patchset to Andrew for inclusion into -mm? -- Greetings Michael. - To unsubscribe from this list: send the line

Re: IV copy strategy

2007-11-19 Thread Herbert Xu
On Mon, Nov 19, 2007 at 01:38:41PM +0300, Evgeniy Polyakov wrote: > > > Users requiring chaining would then do > > > > crypto_alloc_blkcipher("foo", 0, CRYPTO_ALG_CIPHER_NOCHAIN) > > Hmm, users who want chaining will set flag _NOCHAIN :) > I would call it something more informative... Yes I

Re: IV copy strategy

2007-11-19 Thread Evgeniy Polyakov
On Sun, Nov 18, 2007 at 02:52:37PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote: > > > > That's a question - should it copy IV back or not? > > Currently it is not required by crypto users. > > OK I've changed my mind :) > > The r

Re: [HIFN 00/03]: RNG support v2

2007-11-19 Thread Evgeniy Polyakov
Hi Patrick. On Sun, Nov 18, 2007 at 10:32:52PM +0100, Patrick McHardy ([EMAIL PROTECTED]) wrote: > These patches add support for using the HIFN rng. > Patrick McHardy (3): > [HWRNG]: move status polling loop to data_present callbacks > [HIFN]: Improve PLL initialization > [HIFN