Re: [patch 2/2] remove similar aes glue code

2007-11-10 Thread Herbert Xu
On Sat, Nov 10, 2007 at 10:20:00PM +0100, Sebastian Siewior wrote: > * Herbert Xu | 2007-11-10 19:19:55 [+0800]: > > >On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote: > >> > >> static struct crypto_alg aes_alg = { > >> - .cra_name = "aes", > >> - .cra_drive

Re: [PATCH] [crypto] geode: add fallback for unsupported modes, take 2

2007-11-10 Thread Sebastian Siewior
* Herbert Xu | 2007-11-10 19:31:30 [+0800]: >On Sun, Nov 04, 2007 at 09:59:23PM +0100, Sebastian Siewior wrote: >> The Geode AES crypto engine supports only 128 bit long key. This >> patch adds fallback for other key sizes which are required by the >> AES standard. >> >> Cc: Jordan Crouse <[EMAIL

Re: [patch 0/2] remove setkey function in VIA's padlock

2007-11-10 Thread Sebastian Siewior
* Michal Ludvig | 2007-11-05 12:54:50 [+1300]: > I'll test and get back to you. thx. > >> I have one question regarding the size of the expanded key: You reserve >> 64 * 4 bytes for each key but it seems that you use only 60 * 4 bytes. >> Are the other bytes used by the hardware or did you alloca

Re: [patch 2/2] remove similar aes glue code

2007-11-10 Thread Sebastian Siewior
* Herbert Xu | 2007-11-10 19:19:55 [+0800]: >On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote: >> >> static struct crypto_alg aes_alg = { >> -.cra_name = "aes", >> -.cra_driver_name= "aes-x86_64", >> +.cra_name =

Re: geode: fix not inplace encryption

2007-11-10 Thread Sebastian Siewior
* Herbert Xu | 2007-11-10 19:39:14 [+0800]: >On Tue, Nov 06, 2007 at 02:30:40PM -0700, Jordan Crouse wrote: >> On 06/11/07 21:01 +0100, Sebastian Siewior wrote: >> > Currently the Geode AES module fails to encrypt or decrypt if >> > the coherent bits are not set what is currently the case if the >

Re: [1/1] HIFN: schedule callback invocation to tasklet.

2007-11-10 Thread Herbert Xu
On Fri, Nov 09, 2007 at 09:31:56PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 09, 2007 at 07:12:14PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > This patch forces HIFN driver to invoke crypto request callbacks from > > tasklet (softirq context) instead of hardirq context, since netw

Re: [PATCH] [CRYPTO] Extend sha256_generic.c to support SHA-224and SHA-224-HMAC

2007-11-10 Thread Herbert Xu
On Wed, Nov 07, 2007 at 07:59:23PM +, Jonathan Lynch wrote: > Resubmitting this patch which extends sha256_generic.c to support SHA-224 as > described in FIPS 180-2 and RFC 3874. HMAC-SHA-224 as described in RFC4231 > is then supported through the hmac interface. Patch applied. Thanks. --

Re: geode: fix not inplace encryption

2007-11-10 Thread Herbert Xu
On Tue, Nov 06, 2007 at 02:30:40PM -0700, Jordan Crouse wrote: > On 06/11/07 21:01 +0100, Sebastian Siewior wrote: > > Currently the Geode AES module fails to encrypt or decrypt if > > the coherent bits are not set what is currently the case if the > > encryption does not occur inplace. However, th

Re: [PATCH] [crypto] geode: add fallback for unsupported modes, take 2

2007-11-10 Thread Herbert Xu
On Sun, Nov 04, 2007 at 09:59:23PM +0100, Sebastian Siewior wrote: > The Geode AES crypto engine supports only 128 bit long key. This > patch adds fallback for other key sizes which are required by the > AES standard. > > Cc: Jordan Crouse <[EMAIL PROTECTED]> > Signed-off-by: Sebastian Siewior <[E

Re: [patch 1/2] AES i586, remove setkey

2007-11-10 Thread Herbert Xu
On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote: > The setkey() function can be shared with the generic algorithm. > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Appled. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTEC

Re: [patch 2/2] remove similar aes glue code

2007-11-10 Thread Herbert Xu
On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote: > > static struct crypto_alg aes_alg = { > - .cra_name = "aes", > - .cra_driver_name= "aes-x86_64", > + .cra_name = "aes", > + .cra_driver_name=