On Mon, Oct 22, 2007 at 07:22:12PM +0200, Sebastian Siewior wrote:
> From: Sebastian Siewior <[EMAIL PROTECTED]>
>
> There are three AES softwore modules in the kernel: One C version
> and two arch specific assembly versions. The key expansion routine as
> well as the the four lookup tables which
Michael Halcrow <[EMAIL PROTECTED]> wrote:
>
> I am familiar with CryptoDev and Cryproc. Will you be implementing
> anything similar to what these projects are currently doing? Or do you
> have something else entirely in mind?
I don't have any concrete plans at the moment. So any proposals
would
On Wed, Oct 24, 2007 at 09:19:05AM +0800, Herbert Xu wrote:
> These paths can be triggered from user-space in future so printks
> are not appropriate.
I am familiar with CryptoDev and Cryproc. Will you be implementing
anything similar to what these projects are currently doing? Or do you
have some
On Tue, Oct 23, 2007 at 07:59:22PM -0500, Michael Halcrow wrote:
>
> It is usually appropriate to print something to the system log when
> there is an error condition in the kernel code. That can help triage
> down the road when people have troubles.
>
> The only reason I can think of as to why we
On Wed, Oct 24, 2007 at 08:42:30AM +0800, Herbert Xu wrote:
> On Tue, Oct 23, 2007 at 03:40:08PM -0500, Michael Halcrow wrote:
> > On Tue, Oct 23, 2007 at 03:26:29PM -0500, Joy Latten wrote:
> > > + unsigned int countersize;
> >
> > It's somewhat nicer to just use size_t in the kernel for these so
On Tue, Oct 23, 2007 at 03:40:08PM -0500, Michael Halcrow wrote:
> On Tue, Oct 23, 2007 at 03:26:29PM -0500, Joy Latten wrote:
> > + unsigned int countersize;
>
> It's somewhat nicer to just use size_t in the kernel for these sorts
> of data types. If you care about the exact number of bytes use
On Tue, Oct 23, 2007 at 03:26:29PM -0500, Joy Latten wrote:
> + unsigned int countersize;
It's somewhat nicer to just use size_t in the kernel for these sorts
of data types. If you care about the exact number of bytes used by the
variable, types like u32 make the code more parsable.
> + e
This patch adds countersize to CTR mode.
The template is now ctr(algo,noncesize,ivsize,countersize).
For example, ctr(aes,4,8,4) indicates the counterblock
will be composed of a salt/nonce that is 4 bytes, an iv
that is 8 bytes and the counter is 4 bytes.
When noncesize + ivsize + countersize ==
On Mon, Oct 22, 2007 at 04:01:18PM -0500, Joy Latten wrote:
>
> So ctr(aes,0,16,4) would indicate to use last 4 bytes
> of IV for counter.
>
> Does this seem ok?
Yeah that looks fine. Although GCM also has a salt/IV split
so it'd use ctr(aes,4,12,4).
> Would there be some concern of user initi
