On Thu, Sep 27, 2007 at 05:29:04PM -0500, Joy Latten wrote:
>
> Thus if user enters template without whitespaces,
> then the above would cause a problem because the
> name in the template would not match up with the name
> in the instance above.
Indeed, white spaces are not allowed so they shoul
On Thu, Sep 27, 2007 at 05:25:45PM -0500, Joy Latten wrote:
>
> Shouldn't p be incremented after this check? Otherwise, it will
> still be pointing to ')' after breaking from this for-loop and we will
> end up copying "hmac(sha1" instead of "hmac(sha1)", right?
> Also, I think we will prematurely
Sorry, I really messed up my Subject header.
This comment was for [PATCH 2/8] [CRYPTO] aead: Add support for
multiple template parameters in the patchset.
The second patch in patch set, not the eighth.
Joy
On Thu, 2007-09-27 at 17:25 -0500, Joy Latten wrote:
> My apologies for such late notice,
Again, sorry for the late notice, but this just came
to my attention.
+static struct crypto_instance *crypto_authenc_alloc(struct rtattr **tb)
+{
+ struct crypto_instance *inst;
+ struct crypto_alg *auth;
+ struct crypto_alg *enc;
+ struct authenc_instance_ctx *ctx;
+
My apologies for such late notice, but I observed this only recently
and wanted to point it out.
if (!try_module_get(THIS_MODULE))
goto err;
@@ -101,33 +106,73 @@ static int cryptomgr_schedule_probe(struct crypto_larval
*larval)
memcpy(param->template, name, le
This patch implements CTR mode for IPSec and includes
improvements pointed out in review. It is based off of RFC 3686.
Please note:
1. The CTR mode counterblock is composed of,
nonce + IV + counter.
The size of counterblock is equivalent to the blocksize
of the cipher.
