Re: proposed XTS implementation

2007-09-06 Thread Herbert Xu
On Mon, Sep 03, 2007 at 11:53:13PM +0200, [EMAIL PROTECTED] wrote: > > Herbert: I need to instances of AES, did I do that correctly? Yep it's perfect. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~he

Re: [PATCH] an XTS blockcipher mode implementation without partial blocks

2007-09-06 Thread Herbert Xu
On Thu, Sep 06, 2007 at 04:57:26PM +0200, [EMAIL PROTECTED] wrote: > > I'd rather tell the compiler what I want than to introduce a new local > variable and a conditional branch in the hope that the compiler will > optimize it away, just to avoid a goto. Yes this code looks OK to me. Cheers, --

[PATCH] an XTS blockcipher mode implementation without partial blocks

2007-09-06 Thread Rik Snel
XTS currently considered to be the successor of the LRW mode by the IEEE1619 workgroup. LRW was discarded, because it was not secure if the encyption key itself is encrypted with LRW. XTS does not have this problem. The implementation is pretty straightforward, a new function was added to gf128mul

Re: [PATCH] an XTS blockcipher mode implementation without partial blocks

2007-09-06 Thread rsnel
Hello Sebastian, Thanks for your review of the patch. I will address your points below. On Wed, Sep 05, 2007 at 02:29:06AM +0200, Sebastian Siewior wrote: > >diff --git a/crypto/xts.c b/crypto/xts.c > [...] > >+/* key consists of keys of equal size concatenated, therefore > >+ * the lengt