Re: 2.6.23-rc4-mm1

2007-09-01 Thread Herbert Xu
On Sun, Sep 02, 2007 at 08:22:42AM +0530, Satyam Sharma wrote: > > So what finally got exported out of crypto/ to the rest of the kernel > was just the crypto_alloc_xxx() wrapper. That resolves to a call to > crypto_alloc_base() in crypto/api.c, which first loads the specific > low-level algo modul

Re: 2.6.23-rc4-mm1

2007-09-01 Thread Satyam Sharma
On Sun, 2 Sep 2007, Herbert Xu wrote: > > On Sun, Sep 02, 2007 at 02:39:15AM +0530, Satyam Sharma wrote: > > > > Tangential, but I've often wondered what are the upsides of keeping > > CONFIG_CRYPTO_ALGAPI as a separate config option in the first place? Every > > single item in crypto/ ends up

Re: 2.6.23-rc4-mm1

2007-09-01 Thread Herbert Xu
On Sun, Sep 02, 2007 at 02:39:15AM +0530, Satyam Sharma wrote: > > Tangential, but I've often wondered what are the upsides of keeping > CONFIG_CRYPTO_ALGAPI as a separate config option in the first place? Every > single item in crypto/ ends up "select"ing it (directly or transitively) > so it mak

Re: 2.6.23-rc4-mm1

2007-09-01 Thread Satyam Sharma
On Sat, 1 Sep 2007, Herbert Xu wrote: > On Fri, Aug 31, 2007 at 11:58:15PM -0700, Andrew Morton wrote: > > > > > crypto/built-in.o: In function `update2': > > > digest.c:(.text+0x94a): undefined reference to `crypto_km_types' > > > digest.c:(.text+0x9bf): undefined reference to `crypto_km_types

Re: 2.6.23-rc4-mm1

2007-09-01 Thread Herbert Xu
On Fri, Aug 31, 2007 at 11:58:15PM -0700, Andrew Morton wrote: > > > crypto/built-in.o: In function `update2': > > digest.c:(.text+0x94a): undefined reference to `crypto_km_types' > > digest.c:(.text+0x9bf): undefined reference to `crypto_km_types' > > > > digest.c (CONFIG_CRYPTO) uses crypto/sca