Re: [PATCH] crypto/aes.c remove operator ? and variable t in bf_setkey

2007-07-15 Thread Herbert Xu
On Mon, Jul 16, 2007 at 02:52:34AM +0200, Frederik Sdun wrote: > > this removes the the ? operator which is false nearly all the time. These changes look good. Could you please resend them as patches that can be directly applied and add a sign-off? You can refer to Documentation/SubmittingPatche

[PATCH] crypto/aes.c remove operator ? and variable t in bf_setkey

2007-07-15 Thread Frederik Sdun
Hi, this removes the the ? operator which is false nearly all the time. --- aes.c.orig 2007-07-15 11:43:21.0 +0200 +++ aes.c 2007-07-16 01:56:49.0 +0200 @@ -156,9 +156,12 @@ p = (p << 1) ^ (p & 0x80 ? 0x01b : 0); } + + sbx_tab[0] = 0x63; +

Re: Crypto Update for 2.6.23

2007-07-15 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 15 Jul 2007 21:15:57 +0800 > On Sat, Jul 14, 2007 at 11:48:39PM -0700, David Miller wrote: > > Herbert can you contact the async_tx author to make sure that > > his crypto/ bits go through you in the future so that conflicts > > like this can be avoi

Re: Crypto Update for 2.6.23

2007-07-15 Thread Herbert Xu
On Sat, Jul 14, 2007 at 11:48:39PM -0700, David Miller wrote: > > I merged this into my net-2.6 tree, there was a tiny conflict > in crypto/Kconfig I had to resolve because of the async_tx > stuff that went in upstream. Thanks! > Herbert can you contact the async_tx author to make sure that > his

[2.6 patch] drivers/crypto/Kconfig: hardware drivers shouldn't "default m"

2007-07-15 Thread Adrian Bunk
Hardware drivers shouldn't default to m. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/crypto/Kconfig |5 - 1 file changed, 5 deletions(-) --- linux-2.6.22-rc6-mm1/drivers/crypto/Kconfig.old 2007-07-14 06:25:27.0 +0200 +++ linux-2.6.22-rc6-mm1/drivers/crypto/K