Re: [PATCH 3/4] Twofish cipher - i586 assembler

2006-06-04 Thread Horst von Brand
Joachim Fritschi <[EMAIL PROTECTED]> wrote: > This patch adds the twofish i586 assembler routine. What performance impact does this have on a variety of machines? Is twofish used enough for this to be relevant? -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento d

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-04 Thread Dag Arne Osvik
Andi Kleen wrote: > On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: >> This patch adds the twofish x86_64 assembler routine. >> +/* Defining a few register aliases for better reading */ > > Maybe you can read it now better, but for everybody else it is extremly > confusing. It would be bet

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-04 Thread Andi Kleen
On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: > This patch adds the twofish x86_64 assembler routine. > > Changes since last version: > - The keysetup is now handled by the twofish_common.c (see patch 1 ) > - The last round of the encrypt/decrypt routines where optimized saving 5 > instruct

[PATCH 3/4] Twofish cipher - i586 assembler

2006-06-04 Thread Joachim Fritschi
This patch adds the twofish i586 assembler routine. Changes since the last version: - The keysetup is now handled by the twofish_common.c (see patch 1 ) Correctness was verified with the tcrypt module and automated test scripts. Signed-off-by: Joachim Fritschi <[EMAIL PROTECTED]> diff -uprN li

[PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-04 Thread Joachim Fritschi
This patch adds the twofish x86_64 assembler routine. Changes since last version: - The keysetup is now handled by the twofish_common.c (see patch 1 ) - The last round of the encrypt/decrypt routines where optimized saving 5 instructions. Correctness was verified with the tcrypt module and aut

[PATCH 2/4] Twofish cipher - priority fix

2006-06-04 Thread Joachim Fritschi
This patch adds a proper driver name and priority to the generic c implemtation to allow coexistance of c and assembler modules. Signed-off-by: Joachim Fritschi <[EMAIL PROTECTED]> diff -uprN linux-2.6.17-rc5.twofish/crypto/twofish_c.c linux-2.6.17-rc5.twofish2/crypto/twofish_c.c --- linux-2.6.