Re: [CRYPTO] tcrypt: return -EAGAIN from module_init()

2006-05-29 Thread Herbert Xu
On Tue, May 30, 2006 at 04:42:23PM +1200, Michal Ludvig wrote: > > while we're on tcrypt ... I use this patch to prevent successful loading > of tcrypt. It does all its work, then returns -EAGAIN and is removed > from the kernel. It saves me one "rmmod tcrypt" that I otherwise keep > forgetting to

[CRYPTO] tcrypt: return -EAGAIN from module_init()

2006-05-29 Thread Michal Ludvig
Hi Herbert, while we're on tcrypt ... I use this patch to prevent successful loading of tcrypt. It does all its work, then returns -EAGAIN and is removed from the kernel. It saves me one "rmmod tcrypt" that I otherwise keep forgetting to issue ;-) I found it convenient. Take it or drop it. Micha

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Michal Ludvig
Herbert Xu wrote: > On Mon, May 29, 2006 at 09:37:35PM +1200, Michal Ludvig wrote: > >> BTW how about the digest-speed thing? > > That's fine by me if you can rebase it on the current code set. Attached. Michal This patch adds speed tests (benchmarks) for digest algorithms. Tests are run with d

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Herbert Xu
On Mon, May 29, 2006 at 09:37:35PM +1200, Michal Ludvig wrote: > > This is a testing module only. Who use it? I guess just developers when > working on crypto stuff - they (we) won't be scaried by the ever growing > tcrypt.[ch] I guess. The question is really who has to maintain it :) > Even

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Michal Ludvig
Herbert Xu wrote: Hi Michal: On Thu, May 25, 2006 at 09:27:20AM +1200, Michal Ludvig wrote: It's not a rocket science. It does, however, introduce backward incompatibility. But I don't think that would be a problem - it's a module only for testing anyway. I like the concept. But I think you

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Herbert Xu
Hi Michal: On Thu, May 25, 2006 at 09:27:20AM +1200, Michal Ludvig wrote: > > It's not a rocket science. It does, however, introduce backward > incompatibility. But I don't think that would be a problem - it's a > module only for testing anyway. I like the concept. But I think you should be mor