Re: Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Herbert Xu
On Mon, May 22, 2006 at 04:19:28PM +1200, Michal Ludvig wrote: > > Then we could add a compile-time option (in Kconfig) for the default and > set it to sha1-i586 once that is available. Or have a list of default > fallbacks like sha1_fallback=sha1-i586,sha1-x86-64,sha1-generic. Neither > is a big

Re: Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Michal Ludvig
Herbert Xu wrote: > In general we want to minimise the number of people who need to tweak > configuration parameters. I have nothing against a module parameter > that selected a specific fallback. However, if a large proportion of > people end up having to set the parameter once we get an assemb

Re: Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Herbert Xu
On Mon, May 22, 2006 at 03:38:36PM +1200, Michal Ludvig wrote: > > That's configurable with module parameters. Defaults to sha1-generic but > you can easily add sha1_fallback=sha1-i586 to your modprobe command. To > use padlock or sha1-i586 by default you'll have to edit > /etc/modprobe.conf anywa

Re: Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Michal Ludvig
Herbert Xu wrote: > On Mon, May 22, 2006 at 03:10:38PM +1200, Michal Ludvig wrote: >> Well, not personally, but padlock-sha will. > > How is it going to use these accessors? I'd like to see some code :) The driver_name accessor is used "seriously". The priority accessor is just in one info printk

Re: Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Michal Ludvig
Herbert Xu wrote: > Hi Michal: > > On Mon, May 22, 2006 at 02:15:07PM +1200, Michal Ludvig wrote: >> we should be able to autoload modules via their cra_driver_name, not >> only by the module name. I added a few MODULE_ALIAS()es, for now only >> for aes.ko which sets its driver-name and for SHA1/2

Re: Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Herbert Xu
On Mon, May 22, 2006 at 03:10:38PM +1200, Michal Ludvig wrote: > > Well, not personally, but padlock-sha will. How is it going to use these accessors? I'd like to see some code :) > BTW in padlock fallback path I need to make scatterlist from const char* > buffer. However the macros in scatterli

Re: Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Michal Ludvig
Herbert Xu wrote: > On Mon, May 22, 2006 at 02:20:18PM +1200, Michal Ludvig wrote: >> Add missing accessors for new crypto_alg fields. > > Who's going to use these accessors? Me ;-) Well, not personally, but padlock-sha will. BTW in padlock fallback path I need to make scatterlist from const ch

Re: Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Herbert Xu
Hi Michal: On Mon, May 22, 2006 at 02:15:07PM +1200, Michal Ludvig wrote: > > we should be able to autoload modules via their cra_driver_name, not > only by the module name. I added a few MODULE_ALIAS()es, for now only > for aes.ko which sets its driver-name and for SHA1/256 modules that I > need

Re: Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Herbert Xu
On Mon, May 22, 2006 at 02:20:18PM +1200, Michal Ludvig wrote: > Add missing accessors for new crypto_alg fields. Who's going to use these accessors? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herb

Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Michal Ludvig
Add missing accessors for new crypto_alg fields. Michal Add missing accessors for new crypto_alg fields. Signed-off-by: Michal Ludvig <[EMAIL PROTECTED]> Index: linux/include/linux/crypto.h === --- linux.orig/include/linux/crypto.h

Add MODULE_ALIAS with cra_driver_name

2006-05-21 Thread Michal Ludvig
Hi Herbert, we should be able to autoload modules via their cra_driver_name, not only by the module name. I added a few MODULE_ALIAS()es, for now only for aes.ko which sets its driver-name and for SHA1/256 modules that I need as fallbacks for padlock-sha. Should I resend this patch with all soft-

Re: [CRYPTO] Pass TFM instead of context into digest algos' final() method

2006-05-21 Thread Herbert Xu
On Mon, May 22, 2006 at 09:57:15AM +1200, Michal Ludvig wrote: > > Attached. Patch applied. Thanks a lot. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/p

Re: [CRYPTO] Pass TFM instead of context into digest algos' final() method

2006-05-21 Thread Michal Ludvig
Herbert Xu wrote: > Hi Michal: > > On Mon, May 22, 2006 at 01:29:54AM +1200, Michal Ludvig wrote: >> attached is an obvious fix for your "Pass TFM instead of CTX" patch. >> Please apply to your GIT tree. > > Thanks for catching this. It looks like I missed the coa_init/coa_exit > calls as well.

Re: [CRYPTO] Pass TFM instead of context into digest algos' final() method

2006-05-21 Thread Herbert Xu
Hi Michal: On Mon, May 22, 2006 at 01:29:54AM +1200, Michal Ludvig wrote: > > attached is an obvious fix for your "Pass TFM instead of CTX" patch. > Please apply to your GIT tree. Thanks for catching this. It looks like I missed the coa_init/coa_exit calls as well. Could you add that to your p

[CRYPTO] Pass TFM instead of context into digest algos' final() method

2006-05-21 Thread Michal Ludvig
Hi Herbert, attached is an obvious fix for your "Pass TFM instead of CTX" patch. Please apply to your GIT tree. Michal Pass TFM instead of context into digest algos' final() method. Signed-off-by: Michal Ludvig <[EMAIL PROTECTED]> Index: linux/crypto/digest.c ===

[ACRYPTO] New asynchronous crypto layer release.

2006-05-21 Thread Evgeniy Polyakov
New asynchronous crypto layer acrypto [1] release. It includes new driver for HIFN 7955/7956 adapters, VIA padlock driver, driver for CE-InfoSys FastCrypt PCI card equipped with a SuperCrypt CE99C003B and dm-crypt and IPsec ESP4 engines ported to acrypto. Psec ESP4 transport mode benchmark (scp):