Re: [PATCH] crypto: fix unaligned access in khazad module

2006-04-03 Thread Herbert Xu
On Tue, Apr 04, 2006 at 12:05:18AM +0900, Atsushi Nemoto wrote: > > - K2 = be64_to_cpu(key[0]); > - K1 = be64_to_cpu(key[1]); > + K2 = be64_to_cpu(get_unaligned(&key[0])); > + K1 = be64_to_cpu(get_unaligned(&key[1])); Would it be possible to turn these into two 32-bit aligned read

Re: [PATCH] crypto: add alignment handling to digest layer

2006-04-03 Thread Herbert Xu
On Tue, Apr 04, 2006 at 12:04:07AM +0900, Atsushi Nemoto wrote: > > Some hash modules load/store data words directly. The digest layer > should pass properly aligned buffer to update()/final() method. This > patch also add cra_alignmask to some hash modules. This patch is in my queue. I'll be

Re: [PATCH] crypto: fix unaligned access in khazad module

2006-04-03 Thread Atsushi Nemoto
Ping. This patch can be applied cleanly to 2.6.17-rc1. On 64-bit platform, reading directly from keys (which supposed to be 32-bit aligned) will result in unaligned access. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> diff --git a/crypto/khazad.c b/crypto/khazad.c index 807f2bf..c7e1d25 1

Re: [PATCH] crypto: add alignment handling to digest layer

2006-04-03 Thread Atsushi Nemoto
Ping. This patch can be applied cleanly to 2.6.17-rc1. Some hash modules load/store data words directly. The digest layer should pass properly aligned buffer to update()/final() method. This patch also add cra_alignmask to some hash modules. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]>