Re: [PATCH] crypto: fix key alignment in tcrypt

2006-03-13 Thread Herbert Xu
On Sat, Mar 11, 2006 at 05:48:41PM -0600, Matt Mackall wrote: > > > > Wouldn't it be better to simply move this to the head of the structure? > > > > That wouldn't help, since the whole structure will still be only 8-bit > > aligned. > > Ahh, hadn't noticed the struct was entirely populated by ch

Re: [PATCH] crypto: add missing cra_alignmask

2006-03-13 Thread Herbert Xu
On Wed, Mar 08, 2006 at 11:10:35PM +0900, Atsushi Nemoto wrote: > The "des3_ede" and "serpent" lack cra_alignmask. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> Patch applied. Thanks a lot. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Ho

Re: [2.6 patch] crypto/aes.c: array overrun

2006-03-13 Thread Pavel Machek
On So 11-03-06 13:41:16, Herbert Xu wrote: > On Sat, Mar 11, 2006 at 02:03:39AM +0100, Adrian Bunk wrote: > > > > ... > > #define loop8(i)\ > > ... > > > t ^= E_KEY[8 * i + 7]; E_KEY[8 * i + 15] = t; \ > > } > > > > static int > > aes_set_key(void *ctx_a