On Mon, Oct 24, 2005 at 05:57:06PM +, Nicolas Pitre wrote:
>
> This patch avoids shifting the count left and right needlessly for each
> call to sha1_update(). It instead can be done only once at the end in
> sha1_final().
>
> Keeping the previous test example (sha1_update() successively cal
On Mon, Oct 24, 2005 at 05:57:52PM +, Nicolas Pitre wrote:
>
> The final length buffer construction in sha1_final() is moved just before
> where it is used. This makes for slightly more readable code and actually
> more efficient as well since the compiler doesn't have to bother preserving
> t
On Sat, Nov 12, 2005 at 03:29:24PM -0500, Nicolas Pitre wrote:
>
> Looks fine indeed.
Thanks. I ended up moving src = data out of the if clause as well.
So this is what I committed in the end.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]
On Sun, 13 Nov 2005, Herbert Xu wrote:
> On Mon, Oct 24, 2005 at 05:56:06PM +, Nicolas Pitre wrote:
> >
> > The current code unconditionally copy the first block for every call to
> > sha1_update(). This can be avoided if there is no pending partial block.
> > This is always the case on the
On Mon, Oct 24, 2005 at 05:56:06PM +, Nicolas Pitre wrote:
>
> The current code unconditionally copy the first block for every call to
> sha1_update(). This can be avoided if there is no pending partial block.
> This is always the case on the first call to sha1_update() (if the length
> is >=
