RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
Hi I already tried the solution you suggest below, it works fine but then we only handle one request at a time, and the performance doesn't look good. I also noticed that if I allow to insert up to a specific limit of pending requests lets say 10, then the driver acts fine, and the performance s

RE: OCF or Acrypto for IPSec and dm-crypt

2005-09-04 Thread Ronen Shitrit
Hi YES (like in OCF and in the current cryptoAPI) Sounds good to me, When is this Async Crypto API, going to be ready?? Since I'm planning to take a full month vacation, by the end of this week, and if by the time I will be back, this Async Crypto APIs will be ready, and _part_of_the_mainline_,

Re: OCF or Acrypto for IPSec and dm-crypt

2005-09-04 Thread Herbert Xu
Ronen Shitrit <[EMAIL PROTECTED]> wrote: > > I think, Correct me if I'm wrong, > What you described below, is 1 session with few operations (using the > routing feature of the acrypto), but once the session/set of operations > are done, then the session is closed. I see. You want the session to

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
> Patch attached. diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -85,6 +85,11 @@ struct crypt_config { struct crypto_tfm *tfm; unsigned int key_size; u8 key[0]; + +#if defined CONFIG_ACRYPTO || defined C

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 11:27:24PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi > > I already ported this patch to the OCF, and I'm using it over the OCF. > I also don't see any issue with small partitions?? > > The crypt_convert API is called from 2 different places in the code: > 1. F

RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
Hi I already ported this patch to the OCF, and I'm using it over the OCF. I also don't see any issue with small partitions?? The crypt_convert API is called from 2 different places in the code: 1. For read requests through the kcrypt_do_work working Q, called from bi_end_io of the crypt_clone. 2

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 10:54:46PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi > > Did you tried to format a large partition (let say 10G) encrypted by > dm-crypt with AES-CBC? > I'm trying this and I see, that write and read request are mixing > together. > Why? Cause in the current pa

RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
Hi Did you tried to format a large partition (let say 10G) encrypted by dm-crypt with AES-CBC? I'm trying this and I see, that write and read request are mixing together. Why? Cause in the current patch the Read is blocked until all its fragments will be encrypted, But the Write is not blocked it

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 10:41:02PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi > > What do you think about the second remark?? > " > > ->I think that we might have a problem if a write operation will be > > processed in parallel to a read operation, the read might wait for the > > > w

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 03:51:57PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi > > Nice job, (horoshaya rabota) > Just two issue: > ->I saw this patch is using a global variable which counts the number > pending requests: dm_async_pending. > I think that this variable should be allocate

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 03:51:57PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi Hello, Ronen. > Nice job, (horoshaya rabota) :) thank you. > Just two issue: > ->I saw this patch is using a global variable which counts the number > pending requests: dm_async_pending. > I think that this

RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
Hi Nice job, (horoshaya rabota) Just two issue: ->I saw this patch is using a global variable which counts the number pending requests: dm_async_pending. I think that this variable should be allocated per dm_crypt session, i.e for each crypt_config, since there can be more then 2 consumers readin

Re: OCF or Acrypto for IPSec and dm-crypt

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 08:42:11AM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: > Hi > > I think, Correct me if I'm wrong, > What you described below, is 1 session with few operations (using the > routing feature of the acrypto), but once the session/set of operations > are done, then the se