Re: [Libreoffice-commits] core.git: forms/source framework/source include/osl

On 10/04/2019 07:08, Mike Kaganski wrote: On 10.04.2019 2:11, Thorsten Behrens wrote: So this is apparently about "[API CHANGE] Asserts to never clear already cleared guard". --- a/include

Re: [Libreoffice-commits] core.git: forms/source framework/source include/osl

Hi Thorsten, On 10.04.2019 2:11, Thorsten Behrens wrote: --- a/include/osl/mutex.hxx +++ b/include/osl/mutex.hxx @@ -178,11 +178,9 @@ namespace osl */ void clear() { -if(pT) -{ -pT->release(); -pT = NULL; -

Re: [Libreoffice-commits] core.git: forms/source framework/source include/osl

Hi Mike, Mike Kaganski (via logerrit) wrote: > [API CHANGE] Asserts to never clear already cleared guard > > ... which could help catch copy-paste errors when wrong guard is cleared > second time. > The assert() is quite nice, but: > --- a/include/osl/mutex.hxx > +++ b/include/osl/mut

[Libreoffice-commits] core.git: forms/source framework/source include/osl

forms/source/component/DatabaseForm.cxx |3 forms/source/misc/InterfaceContainer.cxx|1 framework/source/layoutmanager/layoutmanager.cxx| 92 framework/source/layoutmanager/toolbarlayoutmanager.cxx | 22 ++- include/osl/mutex.h