Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro

2011-01-09 Thread Robert Nagy
if we use that simol it might break other versions of db. On (2011-01-10 10:16), Gökçen Eraslan wrote: > Perşembe 06 Ocak 2011 günü (saat 20:03:28) Petr Mladek şunlar?? yazm??şt??: > > Hi, > > > > this fixed the problem described in the attached mail. > > > > Gökçen, Robert, could you please tes

Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro

2011-01-09 Thread Gökçen Eraslan
Perşembe 06 Ocak 2011 günü (saat 20:03:28) Petr Mladek şunları yazmıştı: > Hi, > > this fixed the problem described in the attached mail. > > Gökçen, Robert, could you please test it and sign it out for > libreoffice-3-3 branch? > No, I only have __db185_open_4008 symbol in libdb.so, here is th

Re: [Libreoffice] segfault in libqa_unit.so test

2011-01-09 Thread David Tardon
On Fri, Jan 07, 2011 at 09:52:31AM +, Caolán McNamara wrote: > On Fri, 2011-01-07 at 03:21 +0100, Thomas Klausner wrote: > > Is that the end of the build? > > Yup, good news. > > > (Where did the nice graphics go? ;) ) > > > > Thank you! How do we continue with this? > > Well, make dev-ins

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

2011-01-09 Thread David Tardon
On Mon, Jan 10, 2011 at 06:32:40AM +0100, David Tardon wrote: > On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > > diff --git a/sw/source/core/access/acccell.cxx > > b/sw/source/core/access/acccell.cxx > > index dbd1b51..2479c5c 100644 > > --- a/sw/source/core/access/acccell.cxx > > +

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

2011-01-09 Thread David Tardon
On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: > diff --git a/sw/source/core/access/acccell.cxx > b/sw/source/core/access/acccell.cxx > index dbd1b51..2479c5c 100644 > --- a/sw/source/core/access/acccell.cxx > +++ b/sw/source/core/access/acccell.cxx > @@ -121,7 +121,7 @@ SwAccessibleC

[Libreoffice] [PATCH] cppcheck changes at writer

2011-01-09 Thread Kayo Hamid
Sending for review. revol_ diff --git a/sw/source/core/docnode/ndsect.cxx b/sw/source/core/docnode/ndsect.cxx index a7168c2..f93fe95 100644 --- a/sw/source/core/docnode/ndsect.cxx +++ b/sw/source/core/docnode/ndsect.cxx @@ -387,6 +387,7 @@ SwDoc::InsertSwSection(SwPaM const& rRange, SwSectionDat

[Libreoffice] [PUSHED] Re: [PATCH] some cppcheck cleaning in sw + replacement of -exec by xargs

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 22:25 +0100, Julien wrote: > Hello, > > Here is a patch for some cppcheck cleaning in sw > Compiling was ok Looks reasonable to me, pushed, thanks for these > + 1 -exec replaced by xargs ditto. C. ___ LibreOffice mailing list L

Re: [Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 20:37 +0100, Soeren Moeller wrote: > And here another patch for sc/inc/funcdesc.hxx and related source > files, ... >(using casts when forced to use String originally because of ResId). Kohei will probably want to have a look at these, but as an aside, how about adding somet

[Libreoffice] [PUSHED] Re: [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on

2011-01-09 Thread Rene Engelhard
On Sun, Jan 09, 2011 at 09:24:51PM +, Caolán McNamara wrote: > On Sun, 2011-01-09 at 20:55 +0100, Rene Engelhard wrote: > > OK for libreoffice-3-3? > > yeah, go for it IMO. k, pushed. Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@li

Re: [Libreoffice] [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 20:55 +0100, Rene Engelhard wrote: > OK for libreoffice-3-3? yeah, go for it IMO. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] some cppcheck cleaning in sw + replacement of -exec by xargs

2011-01-09 Thread Julien
Hello, Here is a patch for some cppcheck cleaning in sw Compiling was ok + 1 -exec replaced by xargs Julien (LGPLv3+ / MPL) commit 8bce9aee2348d6d34f190b2409390010b9a88e79 Author: Julien Nabet Date: Sun Jan 9 22:19:39 2011 +0100 Some cppcheck cleaning diff --git a/sw/source/core/acces

[Libreoffice] [PUSHED] Re: [PATCH] cppcheck cleaning in sc

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 16:21 +0100, Julien Nabet wrote: > Hello, > > Here is a patch for some cppcheck cleaning in sc > Compiling was ok Looks good, so pushed. Thanks for this. I did decide afterwards to remove two of the methods that cppcheck said could be "const" seeing as they were actually e

Re: [Libreoffice] Quasi-patch: Cursor vs Scroll

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 23:50 +, Andy Hearn wrote: > The cursor, when on a post-it note, now can go out of view when Joe > User scrolls, and is correctly brought back into 'focus' if the user > types something. > > But however, this patch shouldn't be pushed at all - I suspect that > the hack whi

Re: [Libreoffice] calling web services

2011-01-09 Thread Peter Jentsch
Am 07.01.11 23:24, schrieb Dan Corneanu: > Hi, > supposing I would venture in writing a content provider implemented in > C++ , to make a CMIS repository accessible to libreoffice, > what library should I use for accessing the web services on the server? > > Best regards, > Dan. Hi, I'm not aware

[Libreoffice] [PUSHED] Re: [PATCH] Removed unnecessary comments

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 23:52 +0100, Christina Roßmanith wrote: > Hi, > > instead of translating comments, this time I removed lot's of comments like Looks good, all pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop

[Libreoffice] [PUSHED] Re: [PATCH] Translated comments from German to English

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 23:14 +0100, Christina Roßmanith wrote: > Hi, > > I started with a fresh clone this evening and reapplied my changes. So > this patch is meant for pushing :-) Seems to be a duplicate of the earlier ones which I already pushed, so I think these are up to date now. Thanks fo

Re: [Libreoffice] FOSDEM 2011, Proposed Talk: "Kicking off the LibreOffice Design Team"

2011-01-09 Thread Florian Effenberger
Hi Christoph, Christoph Noack wrote on 2011-01-09 02.51: During the last days, I got the impression that it might be helpful to share some ideas how a future collaboration with the LibreOffice Design Team could look like. And, to know what you consider to be helpful when we talk about UX and Vi

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code and fix typos

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 02:06 +0900, Takeshi Abe wrote: > Hi, > > Here is a bunch of cleanup on base. Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

Re: [Libreoffice] Replacing tools/color.hxx with new type

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 17:29 +0100, Soeren Moeller wrote: > - Is this strategy: "writing new type, adding casts to old type, > replacing occurrences, removing old type" appropriate? Well, whatever works I guess, personally I prefer a big-bang approach. i.e. remove the class in one fell sweep. Depre

[Libreoffice] [PUSHED] Re: [PATCH] Remove commented code

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 14:26 +0100, Anders Jonsson wrote: > These three patches remove large blocks of commented code in sdk, > components and libs-gui respectively. All code has been commented out at > least since 2005. Looks perfectly reasonable to me, especially the comment which suggests the ch

[Libreoffice] [PUSHED] Re: [PATCH] Reducing chmod spawning by replacing exec by xargs

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 14:08 +0100, Julien Nabet wrote: > PS : the 2 sendings with my yahoo.fr address seemed not having worked. They showed up eventually, all pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://

[Libreoffice] [PUSHED] Re: [PATCH] Reducing chmod spawning by replacing exec by xargs

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 02:09 +0100, Julien Nabet wrote: > Hello, > > I used xargs instead of -exec to reduce chmod spawning. Seems reasonable, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freed

Re: [Libreoffice] [PUSHED] Re: [PATCH] Again cppcheck cleanliness

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 08:46 +0100, Julien Nabet wrote: > I don't understand too the part about hiding something from cppcheck, > wouldn't it be better to declare a new bug to cppcheck tracker ? Quite possibly > But perhaps I misunderstood something I reckon we really should be calling cppcheck w

[Libreoffice] [PUSHED] Re: [PATCH] Translations of comments in writer/sw/inc

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 02:53 +0100, Christoph wrote: > some more translations. Looks reasonable to me, pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Transl. German comments in sw/inc/IDocumentFieldsAccess.hxx

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 00:21 +0100, Christoph wrote: > Only one comment in this file. Seems reasonable to me, pushed. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libre

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 --- Comment #58 from tester8 2011-01-09 12:13:11 PST --- Nominate Bug 32052 - hat, vector and tilde doesn't appear. With this bug LibreOffice is unusable for physicist and some other scientists. It is regression to OO 3.2. -- Configure bugmail:

[Libreoffice] Splitting up source/header files for clarity

2011-01-09 Thread Soeren Moeller
Hi I have been working with sc/inc/funcdesc.hxx, and this header defines four closely related classes, but all the implementation of these classes is in sc/source/core/data/global.cxx together with the implementation of a number of other classes. This makes it confusing to find the implementations

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 tester8 changed: What|Removed |Added Depends on||32052 -- Configure bugmail: https://bugs.free

[Libreoffice] [PATCH] fix nsplugin to say LibreOffice; supress message unless debug on

2011-01-09 Thread Rene Engelhard
Hi, see the attached patch, the Mozilla plugin still says "OpenOffice path" (yes, even without .org!) when invoked. Should be changed, And I think we shouldn't show this at all unless someone wants to debug this so I added #idef OSL_DEBUG_LEVEL > 0 around it. OK for libreoffice-3-3? Grüße/Regar

[Libreoffice] libreoffice.org

2011-01-09 Thread Kayo Hamid
Hello, I have seen a new design at libreoffice.org and it's looks very good, congrats! But it seems miss set a blank background. revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreof

[Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

2011-01-09 Thread Soeren Moeller
And here another patch for sc/inc/funcdesc.hxx and related source files, changing even more occurrences of (deprecated) String to OUString. I also changed the uses of these variables/functions to use OUString instead (using casts when forced to use String originally because of ResId). Please revie

[Libreoffice] [PATCH] Changed String to OUString in ScFuncDesc

2011-01-09 Thread Soeren Moeller
Hi Please review and apply if appropriate this patch: I have replaced four public (deprecated) String variables of ScFuncDesc in sc/inc/funcdesc.hxx by OUString and changed all uses of these variables to use OUString instead. Most places by using relevant methods for OUString, and a few places (wh

Re: [Libreoffice] Linux distros and LibO packaging

2011-01-09 Thread Rene Engelhard
Hi, On Sun, Jan 09, 2011 at 05:39:31PM +0100, Rene Engelhard wrote: > On Sun, Jan 09, 2011 at 04:40:06PM +0100, Jonathan Aquilina wrote: > > Not trying to hijack the thread here but what is Ubuntu doing about > > LO i know its supposed to be part of their next release instead of > > OOo, but norma

Re: [Libreoffice] Linux distros and LibO packaging

2011-01-09 Thread Rene Engelhard
On Sun, Jan 09, 2011 at 04:40:06PM +0100, Jonathan Aquilina wrote: > Not trying to hijack the thread here but what is Ubuntu doing about > LO i know its supposed to be part of their next release instead of > OOo, but normally they get packages from upstream Debian, is someone > working on getting i

Re: [Libreoffice] Formula cursor : bug or feature ?

2011-01-09 Thread Jean-Baptiste Faure
> Hi Jean, > > On Wed, 2010-12-29 at 21:11 +0100, Jean-Baptiste Faure wrote: >> Jonas wrote: >>> Assuming someone cares to implement it... and you're are welcome to >>> step up to the plate :) > .. >> I strongly disagree : it is you who must not to destroy what is working >> very well. > Jean

Re: [Libreoffice] Linux distros and LibO packaging

2011-01-09 Thread Jonathan Aquilina
Not trying to hijack the thread here but what is Ubuntu doing about LO i know its supposed to be part of their next release instead of OOo, but normally they get packages from upstream Debian, is someone working on getting it in Debian? On 01/09/2011 04:11 PM, Jean-Baptiste Faure wrote: Hi al

[Libreoffice] [PATCH] cppcheck cleaning in sc

2011-01-09 Thread Julien Nabet
Hello, Here is a patch for some cppcheck cleaning in sc Compiling was ok Julien PS : when cppcheck indicates that a boolean is not initialized, what is recommended to choose ? true, false or it depends on the context ? (LGPLv3+ / MPL) commit dd245b64fb571acffb4dc580d0f6098a0cf5037b Author: Ju

[Libreoffice] Linux distros and LibO packaging

2011-01-09 Thread Jean-Baptiste Faure
Hi all, I think that we should have a webpage where Linux distributions who are packaging LibO, could list what changes they made compared to the "official" build by TDF. I see two main advantages : - for users and helpers : they will know easier if a problem comes from LibO or from packaging - f

[Libreoffice] [PUSHED] Re: [PATCH 1/2] Translated comments from German to English

2011-01-09 Thread Caolán McNamara
On Fri, 2011-01-07 at 21:30 +0100, Christina Roßmanith wrote: > The 2nd patch just removes some white spaces and leftover conflict > markers. I hope the two patches together are fine... I fiddled these patches a bit to apply and remove the lines that just changed whitespace and some other cleanup

Re: [Libreoffice] Strange sorting of top level menu

2011-01-09 Thread Jean-Baptiste Faure
Le 06/01/2011 19:33, leif a écrit : > When I see the Startcenter I see the Insert to the most right position > and not as expected between View and Tools. This occurs only when the > start center is visible. When I start or open a document the position is > correct. > > Screendump: > http://picasaw

Re: [Libreoffice] Bug 32790 fixed - please review

2011-01-09 Thread Caolán McNamara
On Sat, 2011-01-08 at 18:26 -0500, Kohei Yoshida wrote: > Hi there, > > I've just fixed and attached a patch to > > https://bugs.freedesktop.org/show_bug.cgi?id=32790 > > intended for 3.3. I would appreciate it if someone who is experienced > in the writer mail merge code to review and approve

[Libreoffice] Regression in PDF-Export: background color of a hatching not exported

2011-01-09 Thread Andreas Mantke
Hi, a user gave me a hint on our de-users-list about a posible regression in LO (OOo) 3.3.0 to OOo 3.2.1. I made some tests and can confirm a regression. The background color of a hatching is not exported anymore. I created an issue for it and sent a notice to the releases-list of OOo. http://