subject:"\[Libevent\-users\] Missing error checking"

Re: [Libevent-users] Missing error checking

2011-06-08 Thread Nick Mathewson

On Mon, Jun 6, 2011 at 5:29 PM, Gilad Benjamini wrote: > Hi, > Here are a few cases where error checking is missing. Not knowing the code, I > can mostly just point to the issues without suggesting fixes. > > - evthread_set_condition_callbacks - The first half of the function assumes > cbs might

[Libevent-users] Missing error checking

2011-06-06 Thread Gilad Benjamini

Hi, Here are a few cases where error checking is missing. Not knowing the code, I can mostly just point to the issues without suggesting fixes. - evthread_set_condition_callbacks - The first half of the function assumes cbs might be NULL. The second half references cbs without validation - evbuf