Re: [Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-22 Thread Kevin Ko
Oh, shoot. I had just copied and pasted the diff output from my terminal, since I wasn't sure if this mailing list would accept file attachments. That was careless of me, since my terminal extended the line off screen. You're right; port 80 is fine. In fact, you might as well get rid of the thr

Re: [Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-22 Thread Nick Mathewson
On Sat, May 21, 2011 at 4:06 AM, Kevin Ko wrote: > Hi, > Sorry for the delay.  Here's a test case.  I'm not sure if you'll like my > use of the limited broadcast address for simulating an ENETUNREACH error > with a TCP connection, but it's the best that I could think of.  Basically, > we want to t

Re: [Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-21 Thread Kevin Ko
Hi, Sorry for the delay. Here's a test case. I'm not sure if you'll like my use of the limited broadcast address for simulating an ENETUNREACH error with a TCP connection, but it's the best that I could think of. Basically, we want to trigger a non-EINPROGRESS error in evutil_socket_connect() i

Re: [Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-20 Thread Nick Mathewson
On Tue, May 10, 2011 at 2:46 AM, Kevin Ko wrote: > Hi, > > Patch in question: >  - Fix the case when failed evhttp_make_request() leaved request in the queue. >  - > http://levent.git.sourceforge.net/git/gitweb.cgi?p=levent/libevent;a=commit;h=0d6622e > > The above patch introduces a failing asse

Re: [Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-10 Thread Cliff Frey
This looks awesome. Is it possible to add a regression test that triggers the behavior? On Mon, May 9, 2011 at 11:46 PM, Kevin Ko wrote: > Hi, > > Patch in question: > - > Fix the case when failed evhttp_make_request() leaved request in the queue. > - > http://levent.git.sourceforge.net/git/g

[Libevent-users] Bug: evhttp_make_request(), introduced in git commit 0d6622e

2011-05-09 Thread Kevin Ko
Hi, Patch in question: - Fix the case when failed evhttp_make_request() leaved request in the queue. - http://levent.git.sourceforge.net/git/gitweb.cgi?p=levent/libevent;a=commit;h=0d6622e The above patch introduces a failing assertion in evhttp_connection_fail().  This happens because the p