Re: [Libevent-users] [PATCH] uri parsing helpers

2010-10-19 Thread Nick Mathewson
Hi, Pavel (and others)! I've made some some revisions to the original patch here, noted on the sourceforge ticket at https://sourceforge.net/tracker/index.php?func=detail&aid=3037660&group_id=50884&atid=461324 . The big ones are: * It conform to libevent's internal memory-management standards

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-08-20 Thread Mihai Draghicioiu
Great! On Sun, Aug 8, 2010 at 3:57 PM, Pavel Plesov wrote: > On Sun, Aug 8, 2010 at 3:55 PM, Pavel Plesov wrote: > >> I will alter the patch: add evhttp_uri_free(), and suppose there is no >> more need for evhttp_uri_clear(). >> >> >> [1] >> https://sourceforge.net/tracker/?func=detail&aid=3037

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-08-08 Thread Pavel Plesov
On Sun, Aug 8, 2010 at 3:55 PM, Pavel Plesov wrote: > I will alter the patch: add evhttp_uri_free(), and suppose there is no > more need for evhttp_uri_clear(). > > > [1] > https://sourceforge.net/tracker/?func=detail&aid=3037660&group_id=50884&atid=461324 > v3 patch is uploaded as 0001-Introdu

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-08-08 Thread Pavel Plesov
On Sun, Aug 8, 2010 at 2:29 PM, Mihai Draghicioiu wrote: > I suggest either allocating the uri struct in memory or not calling > evhttp_uri_clear at the top of evhttp_uri_parse. When declaring the > uri variable inside a function, it will be uninitialized, so in order > to avoid a crash from evhtt

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-08-08 Thread Mihai Draghicioiu
I suggest either allocating the uri struct in memory or not calling evhttp_uri_clear at the top of evhttp_uri_parse. When declaring the uri variable inside a function, it will be uninitialized, so in order to avoid a crash from evhttp_uri_clear, one has to memset the struct to zero. So I suggest se

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-07-31 Thread Pavel Plesov
On Thu, Jul 15, 2010 at 6:31 AM, Nick Mathewson wrote: > Could you upload it to the sourceforge patch tracker at > https://sourceforge.net/tracker/?group_id=50884&atid=461324 ? > Libevent 2.0.x is currently in feature-freeze, so we won't be merging > new externally visible functions (except for s

Re: [Libevent-users] [PATCH] uri parsing helpers

2010-07-14 Thread Nick Mathewson
On Wed, Jul 14, 2010 at 8:43 AM, Pavel Plesov wrote: > This patch introduces evhttp_uri_* functions to deal with URI parsing. > > See evhttp_uri_parse(), evhttp_uri_clear() and evhttp_uri_join() for details. > > Patch is made against Nick's master branch @ github > Thanks for the patch, Pavel! C

[Libevent-users] [PATCH] uri parsing helpers

2010-07-14 Thread Pavel Plesov
This patch introduces evhttp_uri_* functions to deal with URI parsing. See evhttp_uri_parse(), evhttp_uri_clear() and evhttp_uri_join() for details. Patch is made against Nick's master branch @ github --- http.c | 139 ++ include/ev