Re: [Libevent-users] [patch] integer recommendations

2012-04-23 Thread Mansour Moufid
On 2012-04-23, at 12:37 PM, Nick Mathewson wrote: > On Mon, Apr 23, 2012 at 9:04 AM, Mansour Moufid > wrote: >> Hi, >> >> Here's a patch to adhere to a few of the integer-related recommendations in >> the CERT C Secure Coding Standard. I tried not to break anything but you may >> want to doub

Re: [Libevent-users] [patch] integer recommendations

2012-04-23 Thread Mansour Moufid
On 2012-04-23, at 12:33 PM, Mark Ellzey wrote: > On Mon, Apr 23, 2012 at 09:04:59AM -0400, Mansour Moufid wrote: >> Hi, >> >> Here's a patch to adhere to a few of the integer-related recommendations in >> the CERT C Secure Coding Standard. I tried not to break anything but you may >> want to do

Re: [Libevent-users] [patch] integer recommendations

2012-04-23 Thread Nick Mathewson
On Mon, Apr 23, 2012 at 9:04 AM, Mansour Moufid wrote: > Hi, > > Here's a patch to adhere to a few of the integer-related recommendations in > the CERT C Secure Coding Standard. I tried not to break anything but you may > want to double-check. Partial NAK. 2.0.x is a stable release series. It

Re: [Libevent-users] [patch] integer recommendations

2012-04-23 Thread Mark Ellzey
On Mon, Apr 23, 2012 at 09:04:59AM -0400, Mansour Moufid wrote: > Hi, > > Here's a patch to adhere to a few of the integer-related recommendations in > the CERT C Secure Coding Standard. I tried not to break anything but you may > want to double-check. > > Mansour > It seems as if the tool be

Re: [Libevent-users] Request for input on pending bufferevent_openssl patch.

2012-04-23 Thread Hochhaus, Andrew
On Mon, Apr 23, 2012 at 11:20 AM, Nick Mathewson wrote: > And to offer dire warnings where Mark has offered beer: I will > probably be merging this patch, or something quite like it, in the > next 2.0.x-stable release, unless I can make it break or notice some > bug in it.   I'm really hoping that

Re: [Libevent-users] Request for input on pending bufferevent_openssl patch.

2012-04-23 Thread Nick Mathewson
On Fri, Apr 20, 2012 at 4:28 PM, Mark Ellzey wrote: > > Nick agrees this is a fairly nasty bug, and I have attempted to fix the > problem with this patch: > https://github.com/ellzey/Libevent/commit/5cceae1ca32551312a86df7b6fa2576fd0a71ee4 > > But we also both agree that it would be good to have s

Re: [Libevent-users] standalone evbuffer library?

2012-04-23 Thread Nick Mathewson
On Fri, Apr 20, 2012 at 6:49 AM, CheYi Lin wrote: > Hi, > > The evbuffer of libevent 2.0.x is really great. > > Is it possible to have a standalone evbuffer library? > (no locking, no callbacks ... buffer handling only) > > or any suggestion? (other libraries ... etc.) You could probably build th

[Libevent-users] [patch] integer recommendations

2012-04-23 Thread Mansour Moufid
Hi, Here's a patch to adhere to a few of the integer-related recommendations in the CERT C Secure Coding Standard. I tried not to break anything but you may want to double-check. Mansour libevent-2.0.18-stable.INT--.patch Description: Binary data