Re: [Libevent-users] [patch] more testcases

2011-10-19 Thread Nick Mathewson
On Wed, Oct 19, 2011 at 9:58 AM, Leonid Evdokimov wrote: > Here are some patches. > > 0001 fires without following fixes I like it; applying with a few comments and style tweaks. (The style tweak is that I generally do "struct foo *bar;" rather than "struct foo* bar;" because in C syntax, the

Re: [Libevent-users] Re: [PATCH]: libevent/dns DNS_ERR_NOANSWERS

2011-10-19 Thread Nick Mathewson
On Wed, Oct 19, 2011 at 2:50 PM, Leonid Evdokimov wrote: > One more cornercase - reply that has no answers at all should be > treated as NODATA too. It is not malformed message. Right you are. Merging! -- Nick *** To unsubscri

Re: [Libevent-users] Re: [PATCH]: libevent/dns DNS_ERR_NOANSWERS

2011-10-19 Thread Leonid Evdokimov
One more cornercase - reply that has no answers at all should be treated as NODATA too. It is not malformed message. -- WBRBW, Leonid Evdokimov xmpp:l...@darkk.net.ru && http://darkk.net.ru tel:+79816800702 && tel:+79050965222 From 1cd900a52536fb5294f6c13fa759730ea73574a6 Mon Sep 17 00:00:00 2001

Re: [Libevent-users] [PATCH] disclose TTL for negative answers

2011-10-19 Thread Leonid Evdokimov
> Any chance of a unit test on this one? Better late then never :) -- WBRBW, Leonid Evdokimov xmpp:l...@darkk.net.ru && http://darkk.net.ru tel:+79816800702 && tel:+79050965222 From 505d1539e0436355e82054a515d4fabdc6a20e85 Mon Sep 17 00:00:00 2001 From: Leonid Evdokimov Date: Wed, 19 Oct 2011 22

[Libevent-users] [patch] more testcases

2011-10-19 Thread Leonid Evdokimov
Here are some patches. 0001 fires without following fixes aff6ba1 Fix request_finished memory leak with debugging turned on. 9b724b2 Fix evsig_dealloc memory leak with debugging turned on. 0002 is just a preparation for 0003 0003 fires with current codebase but, seems, it should not. I'm sorry,