Re: [Libevent-users] workers for evhttp (was stable, now not!)

2011-05-23 Thread Michael Herf
Nick Mathewson wrote: 1. I added BEV_OPT_THREADSAFE in evhttp_connection_base_new (evcon->bufev = We won't want to do this unconditionally: not everybody will want the overhead of locking in an evhttp that isn't going to be used in multiple threads. Maybe evthread_use_pthreads() could

Re: [Libevent-users] workers for evhttp (was stable, now not!)

2011-05-23 Thread Nick Mathewson
On Sun, May 22, 2011 at 2:35 AM, Michael Herf wrote: > Ok, I made some progress, with help from Google's ThreadSanitizer! > http://code.google.com/p/data-race-test/wiki/ThreadSanitizer > > My libevent's http.c now allows me to hand off an evhttp request to a > worker, which can call evhttp_send_re

Re: [Libevent-users] libevhtp beginnings API

2011-05-23 Thread Kevin Bowling
On Mon, May 23, 2011 at 8:55 AM, Mark Ellzey wrote: >> On Mon, May 16, 2011 at 10:30 PM, Mark Ellzey wrote: >> Are you the copyright holder?  If so, why not stick to BSD to keep >> things simple. >> >> Kevin > > As an FYI, Libevent already does a good job of keeping track of all > non-BSD specifi

Re: [Libevent-users] patch for evhttp_htmlescape() in http.c

2011-05-23 Thread Nick Mathewson
On Mon, May 23, 2011 at 6:20 PM, Mansour Moufid wrote: [...] >> Alternative patch attached: looks ok? > > Looks great to me! Merged; thanks! *** To unsubscribe, send an e-mail to majord...@freehaven.net with unsubscribe libevent

Re: [Libevent-users] patch for evhttp_htmlescape() in http.c

2011-05-23 Thread Mansour Moufid
On Mon, May 23, 2011 at 6:07 PM, Nick Mathewson wrote: > On Mon, May 23, 2011 at 5:54 PM, Mansour Moufid > wrote: >> A couple changes in the file `http.c'. >> >> Removed the `scratch_space' variable from the `evhttp_htmlescape' >> function since it wasn't actually used; also removed the `buf' >>

Re: [Libevent-users] patch for evhttp_htmlescape() in http.c

2011-05-23 Thread Nick Mathewson
On Mon, May 23, 2011 at 5:54 PM, Mansour Moufid wrote: > A couple changes in the file `http.c'. > > Removed the `scratch_space' variable from the `evhttp_htmlescape' > function since it wasn't actually used; also removed the `buf' > variable from the `evhttp_htmlescape' function since it was only

[Libevent-users] patch for evhttp_htmlescape() in http.c

2011-05-23 Thread Mansour Moufid
A couple changes in the file `http.c'. Removed the `scratch_space' variable from the `evhttp_htmlescape' function since it wasn't actually used; also removed the `buf' variable from the `evhttp_htmlescape' function since it was only used by `scratch_space'. Modified the `html_replace' function so

Re: [Libevent-users] libevhtp beginnings API

2011-05-23 Thread Mark Ellzey
> On Mon, May 16, 2011 at 10:30 PM, Mark Ellzey wrote: > Are you the copyright holder? If so, why not stick to BSD to keep > things simple. > > Kevin As an FYI, Libevent already does a good job of keeping track of all non-BSD specific code in their LICENCE file. But.. I have been reconsiderin