Re: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-26 Thread Jack
On 3/26/20 3:17 PM, Dawid Wrobel wrote: [snip] Hello Dawid, Jack, I added the "GUI:" moniker to my commit message, per KDE development guidelines, not sure if you're getting notified somehow about those. Either way, since this is an added functionality, let me know if you want to update

Re: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-26 Thread Dawid Wrobel
Hi, I merged the change to kmymoney master: commit cb1784822d84970c282032fd1125465dc8a5dc27 (HEAD -> master, origin/master) Merge: 3c9fefb51 1a7439d35 Author: Dawid Wróbel Date: Thu Mar 26 15:07:25 2020 -0400 Merge branch 'add_reversing_transaction' GUI: Jack, I added the "GUI:" mon

Fwd: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-26 Thread Dawid Wrobel
On Tue, Mar 24, 2020 at 2:33 PM Thomas Baumgart wrote: Hmm, an addition is usually faster than a multiplication, hence why. That > was > probably written before we had a unary minus operator. > Makes sense. Fixed and pushed. > How do we want to proceed with your changes? I could get them from

Re: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-24 Thread Thomas Baumgart
On Dienstag, 24. März 2020 02:05:33 CET Dawid Wrobel wrote: > On Sat, Mar 21, 2020 at 1:41 PM Thomas Baumgart wrote: > > > Eventually we will do that. Guess I have to learn how to work with those > > pull requests then. > > I am looking forward to this. > > Why do you use > > > > d->m_

Re: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-23 Thread Dawid Wrobel
On Sat, Mar 21, 2020 at 1:41 PM Thomas Baumgart wrote: > Eventually we will do that. Guess I have to learn how to work with those > pull requests then. I am looking forward to this. Why do you use > > d->m_value = d->m_value * MyMoneyMoney::MINUS_ONE; > instead of > d->m_value =

Re: [Patch] Add a reversing transaction to the one(s) currently selected

2020-03-21 Thread Thomas Baumgart
Dawid, On Samstag, 21. März 2020 16:16:43 CET Dawid Wrobel wrote: > I added an option to duplicate selected transaction(s) *and* reverse it > (them). Similar functionality exists in GnuCash. > > The use case is that for some of the transactions you want to easily add a > reversing transaction an

[Patch] Add a reversing transaction to the one(s) currently selected

2020-03-21 Thread Dawid Wrobel
I added an option to duplicate selected transaction(s) *and* reverse it (them). Similar functionality exists in GnuCash. The use case is that for some of the transactions you want to easily add a reversing transaction and assign it to an Income/Expense category. With that in mind, the reversed tra