Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-25 Thread Allan
Hi Alvaro On 25/04/14 12:46, Alvaro Soliverez wrote:> Hi Allan, I haven't really tried it, so it's just an outside view, and you can ignore my comments. No, I welcome all feedback, otherwise it's "This is the way I wrote it, and I know what I really meant." as the OP found out. Don't broad

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-25 Thread Alvaro Soliverez
Hi Allan, Don't broaden the options that much, or at the very least, make the most common use case the easier to follow, and stow away the options for more uncommon usecases. Also, in this case finish is not "import the file" which is already done, but "save settings for next time". That should be

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-25 Thread Allan
On 24/04/14 02:18, Chris wrote: Ok. You got me! Will need to remove the "select file" button from the intermediate pages. There weren't any intermediate pages, but it is now sorted. On completion of each import, control returns to the into page, allowing access to the Skip Setup button, i

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-23 Thread Chris
Ok. You got me! Will need to remove the "select file" button from the intermediate pages. When stepping through the settings, the last pages buttons are a bit confusing you are presented with a finish button and import csv button. I think you should have one or the other not both. A couple of

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-23 Thread Allan
On 23/04/14 13:26, Chris wrote: Hi Allan Hmm looks like my attempt at ascii art failed Three seperate csv imports one after the other without quitting the import dialogue. The third file gets locked in a loop and eventually crashes Each import uses the same settings, with the skip setting chec

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-23 Thread Chris
Sorry guys should have shrunk those images down a fair bit to reduce the size Chris On 23/04/2014 9:56 PM, Chris wrote: Hi Allan Hmm looks like my attempt at ascii art failed Three seperate csv imports one after the other without quitting the import dialogue. The third file gets locked in a

Re: [Kmymoney-devel] csvimport crash on multiple import

2014-04-22 Thread Allan
On 22/04/14 14:24, Chris wrote: I find that when importing 3 banking csv files consecutively with the skip setup button checked, kmymoney crashes. A loop is occuring which eventually exhausts resources. initializePage() calls m_dlg->m_pageLinesDate->validatePage(); which calls m_dlg->m_page

[Kmymoney-devel] csvimport crash on multiple import

2014-04-22 Thread Chris
I find that when importing 3 banking csv files consecutively with the skip setup button checked, kmymoney crashes. A loop is occuring which eventually exhausts resources. initializePage() calls m_dlg->m_pageLinesDate->validatePage(); which calls m_dlg->m_pageCompletion->slotimportclicked()