Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- (Updated Nov. 7, 2014, 7:41 p.m.) Status -- This change has been mar

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/#review70013 --- Ship it! - Christian David On Nov. 7, 2014, 8:06 nachm., Cr

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- (Updated Noie. 7, 2014, 7:06 p.m.) Review request for KMymoney, Skrooge a

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 5, 2014, 6:51 p.m., Thomas Baumgart wrote: > > libalkimia/alkvalue.cpp, line 86 > > > > > > Does this get initialized under all circumstances? > > Cristian Oneț wrote: > It's a static so it's initia

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 5, 2014, 7:51 nachm., Thomas Baumgart wrote: > > libalkimia/alkvalue.cpp, line 86 > > > > > > Does this get initialized under all circumstances? > > Cristian Oneț wrote: > It's a static so it's init

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 5, 2014, 7:51 nachm., Thomas Baumgart wrote: > > libalkimia/alkvalue.cpp, line 86 > > > > > > Does this get initialized under all circumstances? > > Cristian Oneț wrote: > It's a static so it's init

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Noie. 5, 2014, 6:51 p.m., Thomas Baumgart wrote: > > libalkimia/alkvalue.cpp, line 86 > > > > > > Does this get initialized under all circumstances? It's a static so it's initialized once. The purpose of thi

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/#review69912 --- libalkimia/alkvalue.cpp

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- (Updated Noie. 5, 2014, 6:21 p.m.) Review request for KMymoney and Thomas

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/#review69907 --- Looks good to me. I'd vote for 5.0.0 as version due to the ABI

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 2, 2014, 8:24 p.m., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the QSharedDataPointer > > has a c

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 2, 2014, 9:24 nachm., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the QSharedDataPointer > > has a

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 2, 2014, 8:24 p.m., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the QSharedDataPointer > > has a c

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 2, 2014, 9:24 nachm., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the QSharedDataPointer > > has a

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

> On Nov. 2, 2014, 8:24 p.m., Christian David wrote: > > The patch looks good and I like it. It also works on my computer :) > > > > I am just not totaly sure if this patch is ABI compatible. The size of > > AlkValue is unchanged but is that enough? After all the QSharedDataPointer > > has a c

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/#review69687 --- The patch looks good and I like it. It also works on my comput

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- (Updated Oct. 26, 2014, 9:33 p.m.) Review request for KMymoney and Thomas

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- (Updated Oct. 26, 2014, 9:28 p.m.) Review request for KMymoney and Thomas

[Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120815/ --- Review request for KMymoney and Thomas Baumgart. Repository: alkimia De