Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-26 Thread Allan Anderson
> On Nov. 26, 2011, 11:03 a.m., Cristian Oneț wrote: > > Ship It! Thanks for your help. - Allan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8475

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8476 --- Ship it! Now I can use it also :). Although it would be nice to

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8475 --- Ship it! Ship It! - Cristian Oneț On Nov. 21, 2011, 11:50 a.

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-21 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/ --- (Updated Nov. 21, 2011, 11:50 a.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8251 --- kmymoney/plugins/csvimport/csvdialog.cpp

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Allan Anderson
> On Nov. 16, 2011, 9:51 p.m., Cristian Oneț wrote: > > Runtime issues: > > 1. If you go back from step 2 you can't select a file until you reselect > > the import type, although a valid type is already selected > > 2. If I try to import the test.csv file I'm sending by mail to you I'm > > gett

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Allan Anderson
> On Nov. 16, 2011, 9:41 p.m., Cristian Oneț wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1253 > > > > > > use constEnd() instead of end() Thanks, Cristian, I'll attend to those. Done. > On

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Cristian Oneț
> On Nov. 16, 2011, 9:51 p.m., Cristian Oneț wrote: > > Runtime issues: > > 1. If you go back from step 2 you can't select a file until you reselect > > the import type, although a valid type is already selected > > 2. If I try to import the test.csv file I'm sending by mail to you I'm > > gett

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Cristian Oneț
On Wednesday 16 November 2011 22:39:25 you wrote: > 1. If you go back from step 2 you can't select a file until you reselect the > import type, although a valid type is already selected. > > That is deliberate, as, selecting the account type loads the appropriate > part of the resource file, which,

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Allan Anderson
> On Nov. 16, 2011, 9:51 p.m., Cristian Oneț wrote: > > Runtime issues: > > 1. If you go back from step 2 you can't select a file until you reselect > > the import type, although a valid type is already selected > > 2. If I try to import the test.csv file I'm sending by mail to you I'm > > gett

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8246 --- Runtime issues: 1. If you go back from step 2 you can't select a

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-16 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8243 --- kmymoney/plugins/csvimport/CMakeLists.txt

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-15 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/ --- (Updated Nov. 15, 2011, 9:09 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-15 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/#review8213 --- The patch file produced by qgit is incomplete, missing several f

[Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-11-15 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103142/ --- Review request for KMymoney. Description --- This was submitted origi

[Kmymoney-devel] Review Request: CSVPlugin wizard version

2011-10-28 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6818/ --- Review request for kmymoney. Description --- The two earlier versions o